Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Wiki Markup
            Immutability helps to supporting security reasoning. It is safe to share immutable objects, without risk that the recipient can modify something that we are relying uponon \[java:[Mettler 2010B|AA. References#Mettler 2010B]\].

Wiki Markup
Programmers could incorrectly expect that declaring a field or variable {{final}} makes the referenced object immutable. Declaring variables that have a primitive type to be {{final}} does prevent changes to their values after initialization (unless the unsupported {{sun.misc.Unsafe}} class is used). However, when the variable has a reference type, the presence of a {{final}} clause in the declaration only makes _the reference itself_ immutable. The {{final}} clause has no effect on the referenced object. Consequently, the fields of the referenced object can be mutable. For example, according to the _Java Language Specification_ \[java:[JLS 2005|AA. References#JLS 05]\], [§4.12.4|http://java.sun.com/docs/books/jls/third_edition/html/typesValues.html#4.12.4], "{{final}} Variables,"

... if If a final variable holds a reference to an array, then the components of the array may be changed by operations on the array, but the variable will always refer to the same array.

...

In this noncompliant code example, the programmer has declared the reference to the point instance to be final, under the incorrect assumption that this doing so prevents modification of the values of the instance fields x and y. The values of the instance fields can be changed after their initialization because the final clause applies only to the reference to the point instance and not to the referenced object.

Code Block
bgColor#ffcccc
class Point {
  private int x;
  private int y;

  Point(int x, int y) {
    this.x = x;
    this.y = y;
  }
  void set_xy(int x, int y) {
    this.x = x;
    this.y = y;
  }
  void print_xy() {
    System.out.println("the value x is: " + this.x);
    System.out.println("the value y is: " + this.y);
  }
}

public class PointCaller {
  public static void main(String[] args) {
    final Point point = new Point(1, 2);
    point.print_xy();

    // change the value of x, y
    point.set_xy(5, 6);
    point.print_xy();
  }
}

...

With this modification, the values of the instance fields become immutable and , consequently , match the programmer's intended usage model.

...

The clone() method returns a copy of the original object that reflects the state of the original object at the moment of cloning. This new object can be used without exposing the original object. Because the caller holds the only reference to the newly cloned instance, the instance fields cannot be changed without the caller's cooperation. This use of the clone() method allows the class to remain securely mutable. (See rule " OBJ04-J. Provide mutable classes with copy functionality to safely allow passing instances to untrusted code.")

The Point class is declared final to prevent subclasses from overriding the clone() method. This enables the class to be suitably used without any inadvertent modifications of the original object. This solution also complies with rule " OBJ04-J. Provide mutable classes with copy functionality to safely allow passing instances to untrusted code."

Noncompliant Code Example (Arrays)

...

As a result, the original array values cannot be modified by a client. Note that a manual deep copy could be required when dealing with arrays of objects. This generally happens when the objects do not export a clone() method. Refer to rule "OBJ06-J. Defensively copy mutable inputs and mutable internal components" for more information.

As before, this method provides direct access to the array objects themselves, which is safe because String is immutable. If the array contained mutable objects, the getItems() method could return a cloned array of cloned objects.

...

Neither the original array values nor the public list can be modified by a client. For more details about unmodifiable wrappers, refer to rule " void SEC14-J. Provide sensitive mutable classes with unmodifiable wrappers. " This solution still applies if the array contains mutable items instead of String.

...

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="19c78220db1415b2-2fb7090f-40754542-bebfa6ad-cc4067269403f395e23f15b3"><ac:plain-text-body><![CDATA[

[java:[Bloch 2008

AA. References#Bloch 08]]

Item 13: Minimize the accessibility of classes and members

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="ca951dc54d812406-198bf00c-42384b4d-acf7bfab-50810f35477c7e5ae2c4c152"><ac:plain-text-body><![CDATA[

[java:[Core Java 2004

AA. References#Core Java 04]]

Chapter 6

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="faaffc8d59e9bcb5-4c23817d-4f034072-b6a6869a-6fa46f7addde607e9167e2fc"><ac:plain-text-body><![CDATA[

[java:[JLS 2005

AA. References#JLS 05]]

[§4.12.4 "final Variables"

http://java.sun.com/docs/books /jls/third_edition/html/typesValues.html#4.12.4] ]]></ac:plain-text-body></ac:structured-macro>

 

§6.6 "Access Control"

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="646e784071c265ef-6dbe3644-46cf4f90-8658a12f-4d5d9ac173343804e3ae1fb9"><ac:plain-text-body><![CDATA[

[java:[Mettler 2010B

AA. References#Mettler 2010B]]

 

]]></ac:plain-text-body></ac:structured-macro>

...