...
This noncompliant code example accepts a value from the user without validating it. Any value that is not in the range of 0 to 255 is truncated. For instance, write(303)
prints /
on ASCII-based systems because the lower-order 8 bits of 303 are used while the 24 high-order bits are ignored (303 % 256 = 47, which is the ASCII code for /
). That is, the result is the remainder of the input divided by 256.
Code Block | ||
---|---|---|
| ||
class ConsoleWrite {
public static void main(String[] args) {
// Any input value > 255 will result in unexpected output
System.out.write(Integer.valueOf(args[0]));
System.out.flush();
}
}
|
...
This compliant solution prints the corresponding character only if the input integer is in the proper range. If the input is outside the representable range of an int
, the Integer.valueOf()
method throws a NumberFormatException
. If the input can be represented by an int
but is outside the range required by write()
, this code throws an ArithmeticException
.
Code Block | ||
---|---|---|
| ||
class FileWrite {
public static void main(String[] args)
throws NumberFormatException, IOException {
// Perform range checking
int value = Integer.valueOf(args[0]);
if (value < 0 || value > 255) {
throw new ArithmeticException("Value is out of range");
}
System.out.write(value);
System.out.flush();
}
}
|
...
This compliant solution uses the writeInt()
method of the DataOutputStream
class, which can output the entire range of values representable as an int
.
Code Block | ||
---|---|---|
| ||
class FileWrite {
public static void main(String[] args)
throws NumberFormatException, IOException {
DataOutputStream dos = new DataOutputStream(System.out);
dos.writeInt(Integer.valueOf(args[0].toString()));
System.out.flush();
}
}
|
...
Automated detection of all uses of the write()
method is straightforward. Sound determination of whether the truncating behavior is correct is not feasible in the general case. Heuristic checks could be useful.
Tool | Version | Checker | Description |
---|---|---|---|
Coverity | 7.5 | CHECKED_RETURN | Implemented |
Related Guidelines
...