Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Wiki Markup
 _Lazy initialization_ defers the construction of a member field or an object referred to by a member field until an instance is actually required, rather than computing the field value or constructing the referenced object in the class's constructor. Lazy initialization helps to break harmful circularities in class and instance initialization . andIt inalso performingenables other optimizations \[[Bloch 2005|AA. Bibliography#Bloch 05]\].

...

Lazy initialization must be synchronized in multithreaded applications , to prevent multiple threads from creating extraneous instances of the member object:

...

The double-checked locking idiom improves performance by limiting synchronization to the rare case of computing the field's value or constructing a new instance for the field to reference , and by foregoing synchronization during the common case of retrieving an already-created instance or value.

Incorrect forms of the double-checked locking idiom include those that allow publication of an uninitialized or partially initialized object. Consequently, only those forms of the double-checked locking idiom that correctly establish a happens-before relationship both for the helper reference and also for the complete construction of the Helper instance are permitted.

...

The double-checked locking pattern uses block synchronization rather than method synchronization , and installs an additional null reference check before attempting synchronization. This noncompliant code example uses the incorrect form of the double-checked locking idiom.

...

Wiki Markup
According to Pugh \[[Pugh 2004|AA. Bibliography#Pugh 04]\]

... writes Writes that initialize the Helper object and the write to the helper field can be done or perceived out of order. As a result, a thread which invokes getHelper() could see a non-null reference to a helper object, but see the default values for fields of the helper object, rather than the values set in the constructor.

Even if the compiler does not reorder those writes, on a multiprocessor, the processor or the memory system may reorder those writes, as perceived by a thread running on another processor.

This code also violates rule TSM03-J. Do not publish partially initialized objects.

...

Variables that are declared static and initialized at declaration , or from a static initializer , are guaranteed to be fully constructed before being made visible to other threads. However, this solution forgoes the benefits of lazy initialization.

...

Wiki Markup
Initialization of the static {{helper}} field is deferred until the {{getInstance()}} method is called. The necessary happens-before relationships are created by the combination of the class loader's actions loading and initializing the {{Holder}} instance, and the guarantees provided by the Java memory model. This idiom is a better choice than the double-checked locking idiom for lazily initializing static fields \[[Bloch 2008|AA. Bibliography#Bloch 08]\].  However, this idiom cannot be used to lazily initialize instance fields \[[Bloch 2001|AA. Bibliography#Bloch 01]\].

...

Code Block
bgColor#ccccff
final class Foo {
  private final ThreadLocal<Foo> perThreadInstance = 
      new ThreadLocal<Foo>();
  private Helper helper = null;

  public Helper getHelper() {
    if (perThreadInstance.get() == null) {
      createHelper();
    }
    return helper;
  }

  private synchronized void createHelper() {
    if (helper == null) {
      helper = new Helper();
    }
    // Any non-null value can be used as an argument to set()
    perThreadInstance.set(this);
  }
}

...

In this compliant solution, suppose that the Helper class is immutable. The Java Memory Model (JMM) guarantees that immutable objects are fully constructed before they become visible to any other thread. Additionally, the block synchronization in the getHelper() method suffices to ensure that all methods that can see a non-null value of the helper field have a proper happens-before relationship for the update to the helper reference. This synchronization and the aforementioned JMM guarantee combine to ensure that only fully - initialized Helper objects are visible to threads that see non-null values. Consequently, this compliant solution correctly creates both of the needed happens-before relationships.

...

Wiki Markup
*LCK10-EX0:* Use of the noncompliant form of the double-checked locking idiom is permitted for 32-bit primitive values (for example, {{int}} or {{float}}) \[[Pugh 2004|AA. Bibliography#Pugh 04]\], although this usage is discouraged. The noncompliant form establishes the necessary happens-before relationship between threads that see an initialized version of the primitive value. The second happens-before relationship (that for the initialization of the fields of the referent) is of no practical value, because unsynchronized reads and writes of primitive values up to 32-bits are guaranteed to be atomic. Consequently, the noncompliant form establishes the only needed happens-before relationship in this case. Note, however, that the noncompliant form fails for {{long}} or {{double}} because unsynchronized reads or writes of 64-bit primitives lack a guarantee of atomicity, and consequently require a second happens-before relationship to guarantee that all threads see only fully assigned 64-bit values (See rule [VNA05-J. Ensure atomicity when reading and writing 64-bit values] for more information.)

Risk Assessment

Using incorrect forms of the double-checked locking idiom can lead to synchronization problems and can expose partially - initialized objects.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

LCK10-J

low

probable

medium

P4

L3

Related Guidelines

MITRE CWE

CWE-609, ". Double-Checked Locking" checked locking

Bibliography

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="cbc06e8ca9e949f0-822452c4-454549c4-9f259ca3-344066391a9e79fdedaab17b"><ac:plain-text-body><![CDATA[

[[API 2006

AA. Bibliography#API 06]]

 

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="86f23569ca3648e6-b452d678-4ecb4a06-96a9b630-41c857c4f7459e0ec10a2c07"><ac:plain-text-body><![CDATA[

[[Bloch 2001

AA. Bibliography#Bloch 01]]

Item 48: ". Synchronize access to shared mutable data "

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="fe5d9fd76941528e-5942eb41-477640c5-a9f5bd8c-b5b6b7e9917866b9a383397e"><ac:plain-text-body><![CDATA[

[[Bloch 2008

AA. Bibliography#Bloch 08]]

Item 71: ". Use lazy initialization judiciously"]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="01e65297bf905069-fcdb5d14-43bd48eb-9c998278-71b1f086881a465904d76472"><ac:plain-text-body><![CDATA[

[[JLS 2005

AA. Bibliography#JLS 05]]

§12.4, " Initialization of Classes and Interfaces "

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="d99f74e53c43f6b6-1d3de1b1-476e4009-8912bbc8-c188ba4f6e06a806bd7ce4a9"><ac:plain-text-body><![CDATA[

[[Pugh 2004

AA. Bibliography#Pugh 04]]

 

]]></ac:plain-text-body></ac:structured-macro>

...