Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Edited by NavBot (jp)

...

Code Block
bgColor#FFCCCC
public class TestWrapper2 {
 public public static void main(String[] args) {
  
  Integer  
  Integer i1 = 100;
         Integer i2 = 100;
         Integer i3 = 1000;
         Integer i4 = 1000;
         System.out.println(i1==i2);
         System.out.println(i1!=i2);
         System.out.println(i3==i4);
         System.out.println(i3!=i4);
    
     
 }
}

Output of this code

Here the cache in the Integer class can only make the number from -127 to 128 refer to the same object, which clearly explains the result of above code. In case of making such mistakes, when we need to do some comparisons of these wrapper class, we should use equal instead "==" (see EXP03-J for details):

...

Code Block
bgColor#CCCCFF
public class TestWrapper2 {
 public public static void main(String[] args) {
  
  Integer  
  Integer i1 = 100;
         Integer i2 = 100;
         Integer i3 = 1000;
         Integer i4 = 1000;
         System.out.println(i1.equals(i2));
         System.out.println(i3.equals(i4));    
 ;    
 }
}  

Noncompliant Code Example

...

Code Block
bgColor#FFCCCC
import java.util.ArrayList;
public class TestWrapper1 {
 public public static void main(String[] args) {
    //create an array list of integers, which each element
    //is more than 127
    &#xA0;&#xA0;&#xA0;&#xA0; ArrayList<Integer> list1 = new ArrayList<Integer>();
    &#xA0;&#xA0;&#xA0;&#xA0; for(int i=0;i<10;i++)
      list1&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;list1.add(i+1000);
  &#xA0;&#xA0;//create another array list of integers, which each element
  &#xA0;&#xA0;//is the same with the first one
    &#xA0;&#xA0;&#xA0;&#xA0; ArrayList<Integer> list2 = new ArrayList<Integer>();
    &#xA0;&#xA0;&#xA0;&#xA0; for(int i=0;i<10;i++)
      list2&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;list2.add(i+1000);    
        
    ;&#xA0;&#xA0;&#xA0;&#xA0;
&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;
&#xA0;&#xA0;&#xA0;&#xA0; int counter = 0;
    &#xA0;&#xA0;&#xA0;&#xA0; for(int i=0;i<10;i++)
      if&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;if(list1.get(i) == list2.get(i)) counter++;
    &#xA0;&#xA0;&#xA0;&#xA0; //output the total equal number
    &#xA0;&#xA0;&#xA0;&#xA0; System.out.println(counter);
 &#xA0;}
} &#xA0;

In JDK 1.6.0_10, the output of this code is 0. In this code, we want to count the same numbers of array list1 and array list2. Undoubtedly, the result is not the same as our expectation. Owning to the fact that the Integer can only caches from -127 to 128, so when int number beyond this range, it will be autoboxed into different objects, then the "==" will return false. But if we can set more caches inside Integer (cache all the integer value (-32K-32K), which means that all the int value could be autoboxed to the same Integer object) then the result may be different!

...

Code Block
bgColor#CCCCFF
public class TestWrapper1 {
 public&#xA0;public static void main(String[] args) {
  &#xA0;&#xA0;//create an array list of integers, which each element
  &#xA0;&#xA0;//is more than 127
    &#xA0;&#xA0;&#xA0;&#xA0; ArrayList<Integer> list1 = new ArrayList<Integer>();
    &#xA0;&#xA0;&#xA0;&#xA0; for(int i=0;i<10;i++)
      list1&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;list1.add(i+1000);
  &#xA0;&#xA0;//create another array list of integers, which each element
  &#xA0;&#xA0;//is the same with the first one
    &#xA0;&#xA0;&#xA0;&#xA0; ArrayList<Integer> list2 = new ArrayList<Integer>();
    &#xA0;&#xA0;&#xA0;&#xA0; for(int i=0;i<10;i++)
      list2&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;list2.add(i+1000);    
        
    &#xA0;&#xA0;&#xA0;&#xA0;
&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;&#xA0;
&#xA0;&#xA0;&#xA0;&#xA0; int counter = 0;
    &#xA0;&#xA0;&#xA0;&#xA0; for(int i=0;i<10;i++)
      if&#xA0;&#xA0;&#xA0;&#xA0; &#xA0;if(list1.get(i).equals(list2.get(i))) counter++;
    &#xA0;&#xA0;&#xA0;&#xA0; //output the total equal number
    &#xA0;&#xA0;&#xA0;&#xA0; System.out.println(counter);
 &#xA0;}
}

In JDK 1.6.0_10, the output of this code is 10.(the reason is the same as the above code example.)

...

Chapter 5, Core Java™ 2 Volume I - Fundamentals, Seventh Edition by Cay S. Horstmann, Gary Cornell
Publisher:Prentice Hall PTR;Pub Date:August 17, 2004.
Section 5.1.7, The Java™ Language Specification,Third Edition by James Gosling, Bill Joy, Guy Steele, Gilad Bracha
Publisher:ADDISON-WESLEY;Pub Date:May 2005.

...

EXP04-J. Be wary of invisible implicit casts      02. Expressions (EXP)      03. Scope (SCP)