Page History

The modulus operator in Java is defined in the Java Language Specification, Second Edition, Section 15 (JLS), §15.17.3, paragraph 3:"Remainder Operator %" [JLS 2013], states,

The remainder operation for operands that are integers after binary numeric promotion (§5§5.6.2) produces a result value such that (a/b)*b+(a%b) is equal to a. This identity holds even in the special case that the dividend is the negative integer of largest possible magnitude for its type and the divisor is -1 (the remainder is 0). It follows from this rule that the result of the remainder operation can be negative only if the dividend is negative, and can be positive only if the dividend is positive; moreover, the magnitude of the result is always less than the magnitude of the divisor.

...

.

The result of the modulus operator implies the following behaviorremainder operator has the same sign as the dividend (the first operand in the expression):

5 % 3 produces 2
5 % (-3) produces 2
(-5) % 3 produces -2
(-5) % (-3) produces  -2

The result has the same sign as the dividend (the first operand in the expression)As a result, code that depends on the remainder operation to always return a positive result is erroneous.

Noncompliant Code Example

In this This noncompliant code example , uses the integer hash references an element of hashKey as an index into the hash table. However, since hash is not guaranteed to be positive, the lookup function may fail, producing a java.lang.ArrayIndexOutOfBoundsException on all negative inputs. array. 

private int sizeSIZE = 16;
	
public int[] hashTablehash = new int[sizeSIZE];
	
public int lookup(int hashhashKey)
 {
  return hashTablehash[hashhashKey % sizeSIZE];
}

A negative hash key produces a negative result from the remainder operator, causing the lookup() method to throw java.lang.ArrayIndexOutOfBoundsException.

Compliant Solution

A This compliant solution can call a function that returns a true (always positive) modulus.calls the imod() method, which always returns a positive remainder:

//* moduloMethod functionimod() givinggives non-negative result */nonnegative result
private int SIZE = 16;
public int[] hash = new int[SIZE];

private int imod(int i, int j)
{ {
  int temp = i % j;
  return (itemp < 0) ? ((-i) % j) temp : (i % j);
}
private int size=16;
	
public int[] hashTable=new int[size];
	
public int lookup(int hash)
{
  return hashTable[imod(i, j)];
}

Or, an explicit range check must be preformed on the numerator.

private int size=16;
	
public int[] hashTable=new int[size];temp; 
  // Unary minus will succeed without overflow  
  // because temp cannot be Integer.MIN_VALUE
}
	
public int lookup(int hashhashKey)
 {
  if(hash < 0)
    return hashTablehash[(-hash) % sizeimod(hashKey, SIZE)];
  return hashTable[hash % size];
}

Risk Assessment

Automated Detection

Unknown

Other Languages

This rule appears in the C Secure Coding Standard as INT10-C. Do not assume a positive remainder when using the % operator, and INT10-CPP. Do not assume a positive remainder when using the % operator,

References

Applicability

Incorrectly assuming a positive remainder from a remainder operation can result in erroneous code.

Automated Detection

Bibliography

...

Image Added Image Added Image AddedJLS 15.17.3