Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

The write() method that is , defined in the class java.io.OutputStream, takes an integer argument intended to be between 0 and argument of type int the value of which must be in the range 0 to 255. Because an int is otherwise designed to store 4 byte numbers, failure to validate user input may lead to unexpected resultsa value of type int could be outside this range, failure to range check can result in the truncation of the higher-order bits of the argument.

The general contract for the write is that () method says that it writes one byte is written to the output stream. The byte to be written is constitutes the eight lowlower-order bits of the argument b. The , passed to the write() method; the 24 high-order bits of b are ignored (see java.io.OutputStream. [JLS 05]write() [API 2014] for more information).

Noncompliant Code Example

The This noncompliant code example accepts a value from the user without validating it. If this Any value is greater than 255, it will result in a wrap aroundthat is not in the range of 0 to 255 is truncated. For instance, write(305) will print '1' since the lower order bits of 305 are preserved while the top 24 order bits are lost303) prints / on ASCII-based systems because the lower-order 8 bits of 303 are used while the 24 high-order bits are ignored (303 % 256 = 47, which is the ASCII code for /). That is, the result is the remainder modulo 256 of the absolute value of the inputinput divided by 256.

Code Block
bgColor#FFcccc

class ConsoleWrite {
  public static void main(String[] args) { 
    // Any input value > 255 will result in unexpected output
    System.out.write(Integer.valueOf(args[0]));
    System.out.flush();
  }
}

Compliant Solution

...

(Range-Check Inputs)

This compliant solution prints the corresponding character only if the input integer is in the proper range. If the input is outside the representable range of an int, the Integer.valueOf() method throws a NumberFormatException. If the input can be represented by an int but is outside the range required by write(), this code throws an ArithmeticExceptionUse alternate means to output integers such as the System.out.print* methods. Again, performing input validation is extremely critical.

Code Block
bgColor#ccccff

class ConsoleWriteFileWrite {
  public static void main(String[] args)
                          throws NumberFormatException, IOException { 
    // Perform inputrange checking  validation
     ifint value = Integer.valueOf(args[0]);
    if <=(value < 0 || value > 255) {
      throw new ArithmeticException("Value is out of range");
    }
  
    System.out.print(args[0]write(value);
    System.out.flush(); 
  }
}

Compliant Solution (writeInt())

This compliant solution uses the writeInt() method of the DataOutputStream class, which can output the entire range of values representable as an int:

Code Block
bgColor#ccccff
class FileWrite {
  public static void main(String[] args)
                      else    throws NumberFormatException, IOException { 
    DataOutputStream dos = new DataOutputStream(System.out);
  //handle error  dos.writeInt(Integer.valueOf(args[0].toString()));
    }System.out.flush(); 
  }     
}

Risk Assessment

Using the write() method to output integers may outside the range 0 to 255 will result in unexpected valuestruncation.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

INT31

FIO09-J

low

Low

unlikely

Unlikely

medium

Medium

P2

L3

Automated Detection

TODO

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

Wiki Markup
\[[Harold 99|AA. Java References#Harold 99]\]

Automated detection of all uses of the write() method is straightforward. Sound determination of whether the truncating behavior is correct is not feasible in the general case. Heuristic checks could be useful.

Tool
Version
Checker
Description
CodeSonar
Include Page
CodeSonar_V
CodeSonar_V

JAVA.NULL.RET.UNCHECKED

Call Might Return Null (Java)

Coverity7.5CHECKED_RETURNImplemented
Parasoft Jtest

Include Page
Parasoft_V
Parasoft_V

CERT.FIO09.ARGWRITEDo not rely on the write() method to output integers outside the range 0 to 255

Related Guidelines

MITRE CWE

CWE-252, Unchecked Return Value

Bibliography


...

Image Added Image Added Image AddedINT30-J. Be careful while casting integers to narrower types      04. Integers (INT)      INT32-J. Perform conversion from BigInteger to String and back properly