Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

On Windows platforms, the CryptGenRandom BCryptGenRandom() function can be used to generate cryptographically strong random numbers. The exact details of the implementation are unknown, including, for example, what source of entropy CryptGenRandom() uses. The Microsoft Developer Network CryptGenRandomBCryptGenRandom() reference [MSDN] states:

The default random number provider implements an algorithm for generating random numbers that complies with the NIST SP800-90 standard, specifically the CTR_DRBG portion of that standardIf an application has access to a good random source, it can fill the pbBuffer buffer with some random data before calling CryptGenRandom(). The CSP [cryptographic service provider] then uses this data to further randomize its internal seed. It is acceptable to omit the step of initializing the pbBuffer buffer before calling CryptGenRandom().

Code Block
bgColor#ccccff
langc
#include <Windows.h>
#include <wincrypt<bcrypt.h>
#include <stdio.h>
 

#pragma comment(lib, "Bcrypt")

void func(void) {
  BCRYPT_ALG_HANDLE Prov;
  HCRYPTPROVint provBuffer;
  if (CryptAcquireContext(&prov, NULL, NULL,
(!BCRYPT_SUCCESS(
          BCryptOpenAlgorithmProvider(&Prov, BCRYPT_RNG_ALGORITHM,
                                      PROV_RSA_FULLNULL, 0))) {
    long/* inthandle li = 0;error */
  }
  if (CryptGenRandom(prov!BCRYPT_SUCCESS(BCryptGenRandom(Prov, sizeof(liPUCHAR), (BYTE *)&li)) {
Buffer),
           printf("Random number: %ld\n", li);
    } else {
      /* Handle error */
    }
    if (!CryptReleaseContext(provsizeof(Buffer), 0))) {
      /* Handlehandle error */
    }
  } else {printf("Random number: %d\n", Buffer);
    /* Handle error */
  }
}BCryptCloseAlgorithmProvider(Prov, 0);
}

Risk Assessment

The use of the rand() function can result in predictable random numbers.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

MSC30-C

Medium

Unlikely

Low

P6

L2

Automated Detection

Tool

Version

Checker

Description

Astrée
Include Page
Astrée_V
Astrée_V
stdlib-use-randFully checked
Axivion Bauhaus Suite

Include Page
Axivion Bauhaus Suite_V

 Supported, but no explicit checker

Axivion Bauhaus Suite_V

CertC-MSC30
Clang
Include Page
Clang_40_V
Clang_40_V
cert-msc30-cChecked by clang-tidy
CodeSonar
Include Page
CodeSonar_V
CodeSonar_V
BADFUNC.RANDOM.RANDUse of rand
Compass/ROSE

 

 

 




Coverity
Include Page
Coverity_V
Coverity_V

DONTCALL

Implemented - weak support
Cppcheck Premium

Include Page
Cppcheck Premium_V
Cppcheck Premium_V

premium-cert-msc30-cFully implemented

ECLAIR

Include Page
ECLAIR_V
ECLAIR_V

CC2.MSC30

Fully implemented

Helix QAC

Include Page
Helix QAC_V
Helix QAC_V

C5022

C++5029


Klocwork
Include Page
Klocwork_V
Klocwork_V

CERT.MSC.STD_RAND_CALL


LDRA tool suite
Include Page
LDRA_V
LDRA_V
44 SEnhanced enforcement
Parasoft C/C++test
Include Page
c:
Parasoft_V
c:Parasoft
Parasoft_V

CERT_C-MSC30-a

Do not use the rand() function for generating pseudorandom numbers
PC-lint Plus

Include Page
PC-lint Plus_V

SECURITY-02

PC-lint Plus_V

586

Fully supported

Polyspace Bug Finder

Include Page

Fully implemented

Polyspace Bug Finder

R2016aVulnerable pseudo-random number generator

_V
Polyspace Bug Finder_V

CERT C: Rule MSC30-CChecks for vulnerable
Using a cryptographically weak
pseudo-random number generator
PRQA QA-C
(rule fully covered)


RuleChecker

Include Page

PRQA QA-C_vPRQA QA-C_v5022

RuleChecker_V
RuleChecker_V

stdlib-use-randFully checked
Fully implemented

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

...

Key here (explains table format and definitions)

Taxonomy

Taxonomy item

Relationship

CERT CMSC50-CPP. Do not use std::rand() for generating pseudorandom numbersPrior to 2018-01-12: CERT: Unspecified Relationship
CERT Oracle Secure Coding Standard for JavaMSC02-J. Generate strong random numbersPrior to 2018-01-12: CERT: Unspecified Relationship
CWE 2.11CWE-327, Use of a Broken or Risky Cryptographic Algorithm2017-05-16: CERT: Rule subset of CWE
CWE 2.11CWE-330, Use of Insufficiently Random Values2017-06-28: CERT: Rule subset of CWE
CWE 2.11CWE-338, Use of Cryptographically Weak Pseudo-Random Number Generator (PRNG)2017-06-28: CERT: Rule subset of CWE
CWE 2.11CWE-6762017-05-18: CERT: Rule subset of CWE

CERT-CWE Mapping Notes

Key here for mapping notes

...

  • Invocation of other dangerous functions, besides rand().


Bibliography

...


...