...
On Windows platforms, the CryptGenRandom BCryptGenRandom()
function can be used to generate cryptographically strong random numbers. The exact details of the implementation are unknown, including, for example, what source of entropy CryptGenRandom()
uses. The Microsoft Developer Network CryptGenRandomBCryptGenRandom()
reference [MSDN] states:
The default random number provider implements an algorithm for generating random numbers that complies with the NIST SP800-90 standard, specifically the CTR_DRBG portion of that standardIf an application has access to a good random source, it can fill the
pbBuffer
buffer with some random data before callingCryptGenRandom()
. The CSP [cryptographic service provider] then uses this data to further randomize its internal seed. It is acceptable to omit the step of initializing thepbBuffer
buffer before callingCryptGenRandom()
.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <Windows.h> #include <wincrypt<bcrypt.h> #include <stdio.h> #pragma comment(lib, "Bcrypt") void func(void) { BCRYPT_ALG_HANDLE Prov; HCRYPTPROVint provBuffer; if (CryptAcquireContext(&prov, NULL, NULL,!BCRYPT_SUCCESS( BCryptOpenAlgorithmProvider(&Prov, BCRYPT_RNG_ALGORITHM, PROV_RSA_FULL, 0)) { long int li = 0; if (CryptGenRandom(prov, sizeof(li), (BYTE *)&li)) { printf("Random number: %ld\n" NULL, li0))); } else { /* Handlehandle error */ } if (!CryptReleaseContext(provBCRYPT_SUCCESS(BCryptGenRandom(Prov, 0)) {(PUCHAR) (&Buffer), /* Handle error */ } } else { /* Handle error */ } } |
Compliant Solution (Windows)
On Windows platforms, the rand_s()
function can be used to generate cryptographically strong random numbers.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <stdio.h> #include <stdlib.h> int func(void) { unsigned int number; errno_t err; err = rand_s( &number); if (err != 0)sizeof(Buffer), 0))) { /* handle error */ } else { printf("Random number: %u%d\n", numberBuffer); } BCryptCloseAlgorithmProvider(Prov, 0); } |
Risk Assessment
The use of the rand()
function can result in predictable random numbers.
...
Tool | Version | Checker | Description | |||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Astrée |
| Supported, but no explicit checkerstdlib-use-rand | Fully checked | |||||||||||
Axivion Bauhaus Suite |
| CertC-MSC30 | ||||||||||||
Clang |
| cert-msc30-c | Checked by clang-tidy | |||||||||||
CodeSonar |
| BADFUNC.RANDOM.RAND | Use of rand | |||||||||||
Compass/ROSE | ||||||||||||||
Coverity |
| DONTCALL | Implemented - weak support | |||||||||||
Cppcheck Premium |
| premium-cert-msc30-c | Fully implemented | |||||||||||
| CC2.MSC30 | Fully implemented | ||||||||||||
Helix QAC |
| C5022 C++5029 | ||||||||||||
Klocwork |
| CERT.MSC.STD_RAND_CALL | ||||||||||||
LDRA tool suite |
| 44 S | Enhanced enforcement | |||||||||||
Parasoft C/C++test |
| CERT_C-MSC30-a | Do not use the rand() function for generating pseudorandom numbers | |||||||||||
PC-lint Plus |
| 586 | Fully supported | |||||||||||
Polyspace Bug Finder |
| Vulnerable pseudo-random number generator | Using a cryptographically weakCERT C: Rule MSC30-C | Checks for vulnerable pseudo-random number generator | PRQA QA-C(rule fully covered) | |||||||||
RuleChecker |
| PRQA QA-C_v |
| stdlib-use-rand | Fully checked | PRQA QA-C_v | 5022 | Fully implemented
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
...
- Invocation of other dangerous functions, besides rand().
Bibliography
[MSDN] | " CryptGenRandom |
[OpenBSD] | arc4random() |
...