...
The C Standard, 6.5, paragraph 2 [ISO/IEC 9899:20112024], states:
If a side effect on a scalar object is unsequenced relative to either a different side effect on the same scalar object or a value computation using the value of the same scalar object, the behavior is undefined. If there are multiple allowable orderings of the subexpressions of an expression, the behavior is undefined if such an unsequenced side effect occurs in any of the orderings.
This requirement must be met for each allowable ordering of the subexpressions of a full expression; otherwise, the behavior is undefined. (see See undefined behavior 3534.)
The following sequence points are defined in the C Standard, Annex C [ISO/IEC 9899:2011]:
- Between the evaluations of the function designator and actual arguments in a function call and the actual call
- Between the evaluations of the first and second operands of the following operators:
- Logical AND:
&&
- Logical OR:
||
- Comma:
,
- Logical AND:
- Between the evaluations of the first operand of the conditional
?:
operator and whichever of the second and third operands is evaluated - The end of a full declarator
- Between the evaluation of a full expression and the next full expression to be evaluated; the following are full expressions:
- An initializer that is not part of a compound literal
- The expression in an expression statement
- The controlling expression of a selection statement (
if
orswitch
) - The controlling expression of a
while
ordo
statement - Each of the (optional) expressions of a
for
statement - The (optional) expression in a
return
statement
- Immediately before a library function returns
- After the actions associated with each formatted input/output function conversion specifier
- Immediately before and immediately after each call to a comparison function, and also between any call to a comparison function and any movement of the objects passed as arguments to that call
Furthermore, Section 6.5.17.1, paragraph 3 [ISO/IEC 9899:2024] says (regarding assignment operations):
The side effect of updating the stored value of the left operand is sequenced after the value computations of the left and right operands.
This rule means that statements such as
...
Code Block | ||||
---|---|---|---|---|
| ||||
/* i is modified twice between sequence points */ i = ++i + 1; /* i is read other than to determine the value to be stored */ a[i++] = i; |
Note that not Not all instances of a comma in C code denote a usage of the comma operator. For example, the comma between arguments in a function call is not a sequence point. However, according to the C Standard, 6.5.23.23, paragraph 10 8 [ISO/IEC 9899:20112024]:
Every evaluation in the calling function (including other function calls) that is not otherwise specifically sequenced before or after the execution of the body of the called function is indeterminately sequenced with respect to the execution of the called function.
This rule means that the order of evaluation for function call arguments is unspecified and can happen in any order.
...
Programs cannot safely rely on the order of evaluation of operands between sequence points. In this noncompliant code example, i
is evaluated twice without an intervening sequence point, and so the behavior of the expression is undefined:
...
Attempting to modify an object multiple times between sequence points may cause that object to take on an unexpected value, which can lead to unexpected program behavior.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
EXP30-C | Medium | Probable | Medium | P8 | L2 |
Automated Detection
Tool | Version | Checker | Description | ||||||
---|---|---|---|---|---|---|---|---|---|
Astrée |
| evaluation-order multiple-volatile-accesses | Fully checked | ||||||
Axivion Bauhaus Suite |
| CertC-EXP30 | |||||||
Clang |
| -Wunsequenced | Detects simple violations of this rule, but does not diagnose unsequenced function call arguments. | ||||||
CodeSonar |
| LANG.STRUCT.SE.DEC | Side Effects in Expression with Decrement | ||||||
Compass/ROSE |
Can detect simple violations of this rule. It needs to examine each expression and make sure that no variable is modified twice in the expression. It also must check that no variable is modified once, then read elsewhere, with the single exception that a variable may appear on both the left and right of an assignment operator | |||||||||
| EVALUATION_ORDER | Can detect the specific instance where a statement contains multiple side effects on the same value with an undefined evaluation order because, with different compiler flags or different compilers or platforms, the statement may behave differently | |||||||
Cppcheck |
| unknownEvaluationOrder | Partially implemented | ||||||
Cppcheck Premium |
| unknownEvaluationOrder | Partially implemented | ||||||
| CC2.EXP30 | Fully implemented | |||||||
GCC |
|
Can detect violations of this rule when the | |||||||||
Helix QAC |
| C0400, C0401, C0402, C0403, C0404, C0405 | Fully implemented | ||||||
Klocwork |
| PORTING.VAR.EFFECTS | Fully implemented | ||||||
LDRA tool suite |
| 35 D |
, 1 Q |
, 9 S, 30 S |
, 134 S |
Fully implemented
0400 [U]
0401 [U]
0402 [U]
0403 [U]
Partially implemented | |||||||||
Parasoft C/C++test |
| CERT_C-EXP30-a | The value of an expression shall be the same under any order of evaluation that the standard permits | ||||||
PC-lint Plus |
| 564 | Partially supported | ||||||
Polyspace Bug Finder |
| CERT C: Rule EXP30-C | Checks for situations when expression value depends on order of evaluation or of side effects (rule partially covered) | ||||||
PVS-Studio |
| V532, V567 | |||||||
RuleChecker |
| evaluation-order multiple-volatile-accesses | Fully checked |
Splint |
|
SonarQube C/C++ Plugin |
| IncAndDecMixedWithOtherOperators |
TrustInSoft Analyzer |
| separated | Exhaustively verified (see one compliant and one non-compliant example). |
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
Related Guidelines
Key here (explains table format and definitions)
Taxonomy | Taxonomy item | Relationship |
---|---|---|
CERT C |
EXP50-CPP. Do not depend on the order of evaluation for side effects | Prior to 2018-01-12: CERT: Unspecified Relationship | |
CERT Oracle Secure Coding Standard for Java | EXP05-J. Do not follow a write by a subsequent write or read of the same object within an expression | Prior to 2018-01-12: CERT: Unspecified Relationship |
ISO/IEC TR 24772:2013 | Operator Precedence/Order of |
Evaluation [JCW] | Prior to 2018-01-12: CERT: Unspecified Relationship | |
ISO/IEC TR 24772:2013 | Side-effects and Order of Evaluation [SAM] | Prior to 2018-01-12: CERT: Unspecified Relationship |
MISRA C:2012 | Rule |
13.2 (required) | CERT cross-reference in MISRA C:2012 – Addendum 3 | |
CWE 2.11 | CWE-758 | 2017-07-07: CERT: Rule subset of CWE |
CERT-CWE Mapping Notes
Key here for mapping notes
CWE-758 and EXP30-C
Independent( INT34-C, INT36-C, MEM30-C, MSC37-C, FLP32-C, EXP33-C, EXP30-C, ERR34-C, ARR32-C)
CWE-758 = Union( EXP30-C, list) where list =
- Undefined behavior that results from anything other than reading and writing to a variable twice without an intervening sequence point.
Bibliography
[ISO/IEC 9899:2011] | Annex C, "Sequence Points" |
[ISO/IEC 9899:2024] | 6.5, "Expressions" 6.5. |
17. |
1, " |
Assignment Operators" |
6.5.3.3, " |
Function Calls" |
[Saks 2007] |
[Summit 2005] | Questions 3.1, 3.2, 3.3, 3.3b, 3.7, 3.8, 3.9, 3.10a, 3.10b, and 3.11 |
...
...