Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Do not use a semicolon on the same line as after an if, for, or while statement condition because this it typically indicates programmer error and can result in unexpected behavior.

Noncompliant Code Example

In this noncompliant code example, a semicolon is used on the same line as immediately following an if statement. condition:

Code Block
bgColor#FFcccc
if (a == b); {
  /* ... */
}

The statements in the apparent body of the if statement are always evaluated regardless of the result of the condition expression.

Compliant Solution

It is likely, in this example, that the semicolon was accidentally inserted.This compliant solution eliminates the semicolon and ensures that the body of the if statement is executed only when the condition expression is true:

Code Block
bgColor#ccccff
if (a == b) {
  /* ... */
}

...

Applicability

Placing a semicolon on the same line as immediately following an if, for, or while statement condition may result in unexpected behavior.

...

Automated Detection

Severity
Tool
Likelihood
Version
Remediation Cost
Checker
Priority
Description

Level

MSC52
PVS-
JG
Studio

low

unlikely

low

P3

L3

Related Guidelines

Include Page
PVS-Studio_V
PVS-Studio_V

V6063
SonarQube
Include Page
SonarQube_V
SonarQube_V
EmptyStatementUsageCheck


Bibliography

[Hatton 1995]

Section 2

§2.7.2, "Errors of

omission

Omission and

addition"

 

Addition"


...

Image Added Image Added Image AddedMSC04-J. Do not leak memory 49. Miscellaneous (MSC) MSC05-J. Do not exhaust heap space