A signal handler should not reassert its desire to handle its own signal. This is often done on non-persistent platforms, that nonpersistent platforms—that is, platforms that, upon receiving a signal, unbind reset the handler for the signal to default behavior SIG_DFL before calling the bound signal handler. Calling signal()
under these conditions presents a race condition. (See SIG01-C. Understand implementation-specific details regarding signal handler persistence.)
A signal handler may only call signal()
only if it does not need to be asynchronous-safe (in other wordsthat is, if all relevant signals are masked , and consequently it may not so that the handler cannot be interrupted).)
...
Noncompliant Code Example
...
In this non-compliant code example, the signal handler handler()
is bound to signum
.
Code Block | ||
---|---|---|
| ||
void handler(int signum) {
signal(signum, handler);
/* handle signal */
}
/* ... */
signal(SIGUSR1, handler);
|
(POSIX)
On nonpersistent platforms, this noncompliant code example On non-persistent platforms, this solution contains a race window, starting when the host environment resets the signal and ending when the handler calls signal()
. During that time, a second signal sent to the program will trigger the default signal behavior, consequently defeating the persistent behavior implied by the call to signal()
from within the handler to reassert the binding.
If the environment is persistent (that is, it does not reset the handler when the signal is received), the handler's signalsignal()
call from within the handler()
function is redundant.
Code Block | ||||
---|---|---|---|---|
| ||||
#include <signal.h>
void handler(int signum) {
if (signal(signum, handler) == SIG_ERR) {
/* Handle error */
}
/* Handle signal */
}
void func(void) {
if (signal(SIGUSR1, handler) == SIG_ERR) {
/* Handle error */
}
} |
Compliant Solution
...
(POSIX)
Calling For persistent platforms, calling the signal()
function from within the signal handler to reassert the binding is unnecessary .for persistent platforms, as in this compliant solution:
Code Block | ||||
---|---|---|---|---|
| ||||
#include <signal.h> void handler(int signum) { /* handleHandle signal */ } /* ... */ void func(void) { if (signal(SIGUSR1, handler); ) == SIG_ERR) { /* Handle error */ } } |
Compliant Solution (POSIX)
POSIX defines the sigaction()
function, which assigns handlers to signals like in a similar manner to signal()
but also allows the caller to explicitly set persistence. Consequently, the sigaction()
function can be used to eliminate the race window on non-persistent OSs.nonpersistent platforms, as in this compliant solution:
Code Block | ||||
---|---|---|---|---|
| ||||
#include <signal.h> #include <stddef.h> void handler(int signum) { /* handleHandle signal */ } /* ... */ void func(void) { struct sigaction act; act.sa_handler = handler; act.sa_flags = 0; if (sigemptyset( &act.sa_mask) != 0) { /* handleHandle error */ } if (sigaction(SIGUSR1, &act, NULL) != 0) { /* handleHandle error */ } } |
While Although the handler in this example does not call signal()
, it could safely do so safely because the signal is masked and consequently the handler cannot be interrupted. If the same handler is installed for more than one signal number, it would be necessary to mask the signals explicitly must be masked explicitly in act.sa_mask
to ensure that the handler cannot be interrupted , because the system masks only masks the signal being delivered.
POSIX recommends that new applications should use sigaction()
and deprecates rather than signal()
. Unfortunately, The sigaction()
function is not C99-compliant defined by the C Standard and is not supported on some platforms, including Windows.
Compliant Solution (Windows)
There is There is no safe way to implement persistent signal-handler behavior on Windows platforms, and consequently it should not be attempted. In cases where If a design depends on this behavior, and the design can not cannot be altered, it may be necessary to claim a deviation from the this rule after completing an appropriate risk analysis.
The reason for this is that Windows is a nonpersistent platform as discussed above. Just before calling the current handler function, Windows resets the handler for the next occurrence of the same signal to SIG_DFL
. If the handler calls signal()
to reinstall itself, there is still a race window. A signal might occur between the start of the handler and the call to signal()
, which would invoke the default behavior instead of the desired handler.
Exceptions
SIG34-C-EX1: On a machine For implementations with persistent signal handlers, it is safe for a handler to modify the behavior for of its own signal. This would Behavior modifications include having ignoring the signal be ignored, reset resetting to the default behavior, or and having the signal handled by a different handler. A handler assigning itself to its own signal reasserting its binding is also safe , as it is a no-op. The handler is impervious to a race condition because multiple invocations of its signal will merely cause it to "interrupt itself" until it manages to reassign its signal.but unnecessary.
The following code example resets a signal handler to the system's default behavior.:
Code Block | ||||
---|---|---|---|---|
| ||||
#include <signal.h> void handler(int signum) { #ifndef WINDOWS #if !defined(_WIN32) if (signal(signum, SIG_DFL); #endif ) == SIG_ERR) { /* handleHandle signalerror */ } #endif /* ...Handle signal */ } void func(void) { if (signal(SIGUSR1, handler); |
...
== SIG_ERR) {
/* Handle error */
}
} |
Risk Assessment
Two signals in quick succession can trigger the a race condition on non-persistent nonpersistent platforms, causing the signal's default behavior despite a handler's attempt to override it.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
SIG34-C |
Low |
Unlikely |
Low | P3 | L3 |
Automated Detection
Tool | Version | Checker | Description | ||||||
---|---|---|---|---|---|---|---|---|---|
Astrée |
| signal-handler-signal-call | Partially checked | ||||||
Axivion Bauhaus Suite |
| CertC-SIG34 | |||||||
CodeSonar |
| BADFUNC.SIGNAL | Use of signal | ||||||
Compass/ROSE | Can detect violations of this rule. However, false positives may occur on systems with persistent handlers | ||||||||
Cppcheck Premium |
| premium-cert-sig34-c | Fully implemented | ||||||
Helix QAC |
| C5021 C++5022 | |||||||
Klocwork |
| MISRA.STDLIB.SIGNAL | |||||||
LDRA tool suite |
| 97 D | Fully implemented | ||||||
Parasoft C/C++test |
| CERT_C-SIG34-a | Properly define signal handlers | ||||||
PC-lint Plus |
| 2762, 2763 | Fully supported | ||||||
| CERT C: Rule SIG34-C | Checks for signal call from within signal handler (rule partially covered) | |||||||
RuleChecker |
| signal-handler-signal-call | Partially checked |
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
References
Wiki Markup |
---|
\[[ISO/IEC 9899-1999TR2|AA. C References#ISO/IEC 9899-1999]\] Section 7.14.1.1, "The {{signal}} function" |
Related Guidelines
Key here (explains table format and definitions)
Taxonomy | Taxonomy item | Relationship |
---|---|---|
CERT C Secure Coding Standard | SIG01-C. Understand implementation-specific details regarding signal handler persistence | Prior to 2018-01-12: CERT: Unspecified Relationship |
ISO/IEC TS 17961:2013 | Calling signal from interruptible signal handlers [sigcall] | Prior to 2018-01-12: CERT: Unspecified Relationship |
...
SIG33-C. Do not recursively invoke the raise() function 11. Signals (SIG) 12. Error Handling (ERR)