Page History

Similarly, a final method parameter obtains an immutable copy of the object reference. Again, this has no effect on the mutability of the referenced data.

Noncompliant Code Example (Mutable Class, final Reference)

In this noncompliant code example, the programmer has declared the reference to the point instance to be final under the incorrect assumption that doing so prevents modification of the values of the instance fields x and y. The values of the instance fields can be changed after their initialization because the final clause applies only to the reference to the point instance and not to the referenced object

When a variable is declared final, it is believed to be immutable. If the variable is a primitive type, it can undoubtedly be made final. If the variable is a reference to an object, however, what appears to be final may not always be.

Noncompliant Code Example

In this example, the values of a and b have been changed. When a reference is declared final, it only signifies that the reference cannot be changed, while the contents that it refers to can still be.

class Point FinalClass{
  private  FinalClassint x;
  private int y;

  Point(int ax, int by) {
    this.ax = ax;
    this.by = by;
  }
  void set_abxy(int ax, int by) {
    this.ax = ax;
    this.by = by;
  }
  void print_abxy() {
    System.out.println("the value ax is: " + this.ax);
    System.out.println("the value by is: " + this.by);
  }
  private int a;
  private int b;
}

public class FinalCallerPointCaller {
  public static void main(String[] args) {
    final FinalClassPoint fcpoint = new FinalClassPoint(1, 2);
    fcpoint.print_abxy();

    //now we changeChange the value of ax,b. y
    fcpoint.set_abxy(5, 6);
    fcpoint.print_abxy();
  }
}

Noncompliant Code Example

Compliant Solution (final Fields)

When the values of the x and y instance variables must remain If a and b have to be kept immutable after their initialization, the simplest approach is to declare them as final.they should be declared final. However, this invalidates a set_xy() method because it can no longer change the values of x and y:

void set_abclass Point {
  private final int x;
  private final int y;

  Point(int ax, int by) {
 //But  now compilerthis.x complains= about set_ab method!
x;
    this.ay = a;
  this.b = b;
 }
 private final int a;
 private final int b;

Unfortunately, now one cannot have setter methods of a and b.

Compliant Solution

y;
  }
  void print_xy() {
    System.out.println("the value x is: " + this.x);
    System.out.println("the value y is: " + this.y);
  }

  // set_xy(int x, int y) no longer possible
}

With this modification, the values of the instance variables become immutable and consequently match the programmer's intended usage model.

Compliant Solution (Provide Copy Functionality)

If the class must remain mutable, another compliant solution is to provide copy functionality. This compliant solution provides a clone() method in the class Point, avoiding the elimination of the setter method:An alternative approach is to provide a clone method in the class. The clone method can be used to get a copy of the original object. Now one can do anything to this new object without affecting the original object.

final public class NewFinalPoint implements Cloneable {
  private int x;
{
 NewFinal(int a  private int y;

  Point(int x, int y) {
    this.x = x;
    this.y = y;
  }
  void set_xy(int x, int by) {
    this.ax = ax;
    this.by = by;
  }
  void print_abxy() {
    System.out.println("the value ax is: "+ this.ax);
    System.out.println("the value by is: "+ this.by);
  }
 void set_ab(int a, int b){
  this.a = a;
  this.b = b;
 }
 public NewFinalpublic Point clone() throws CloneNotSupportedException{
    NewFinalPoint cloned = (NewFinalPoint) super.clone();
    // No need to clone x and y as they returnare cloned;primitives
 }
  private intreturn acloned;
 private int b;}
}

public class NewFinalCallerPointCaller {
  public static void main(String[] args) 
      throws CloneNotSupportedException {
    finalPoint NewFinal nfpoint = new NewFinalPoint(1, 2);    // Is not changed in main()
    nfpoint.print_abxy();
    
    //get Get the copy of original object
    Point pointCopy try {= point.clone();
    // pointCopy now holds a unique NewFinalreference nf2to = nf.clone();the 
    // newly cloned Point instance

    //now we changeChange the value of ax,by of the copy.
          nf2pointCopy.set_abxy(5, 6);

	    //but the originalOriginal value willremains notunchanged
 be changed
	  nfpoint.print_ab();
    } catch (CloneNotSupportedException e) { e.printStackTracexy(); }
  }
}

Another common mistake is to use a public static final array. Clients can trivially modify the contents of the array (although they will not be able to change the array itself, as it is final).

Noncompliant Code Example

With this declaration, {{SOMETHINGS\[1\]}}, etc. can be modified by clients of the code.

public static final SomeType [] SOMETHINGS = { ... };

Compliant Solution

One approach is to make use of the above method: first define a private array and then provide a public method that returns a copy of the array:

private static final SomeType [] SOMETHINGS = { ... };
public static final SomeType [] somethings() {
  return SOMETHINGS.clone();
}

Now the original array values cannot be modified by a client.

Compliant Solution

An alternative approach is to have a private array from which a public immutable list is constructed:

private static final SomeType [] THE_THINGS = { ... };
public static final List<SomeType> SOMETHINGS =
Collections.unmodifiableList(Arrays.asList(THE_THINGS));

Now neither the original array values nor the public list can be modified by any client.

Risk Assessment

Using final to declare the reference to an object is a potential security risk because the contents of the object can still be changed.

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

Chapter 6, Core Java™ 2 Volume I - Fundamentals, Seventh Edition by Cay S. Horstmann, Gary Cornell
Publisher:Prentice Hall PTR;Pub Date:August 17, 2004

The clone() method returns a copy of the original object that reflects the state of the original object at the moment of cloning. This new object can be used without exposing the original object. Because the caller holds the only reference to the newly cloned instance, the instance fields cannot be changed without the caller's cooperation. This use of the clone() method allows the class to remain securely mutable. (See OBJ04-J. Provide mutable classes with copy functionality to safely allow passing instances to untrusted code.)

The Point class is declared final to prevent subclasses from overriding the clone() method. This enables the class to be suitably used without any inadvertent modifications of the original object.

Applicability

Incorrectly assuming that final references cause the contents of the referenced object to remain mutable can result in an attacker modifying an object believed to be immutable.

Bibliography

...

Image Added Image Added Image AddedOBJ02-J. Avoid using finalizers      06. Objects Orientation (OBJ)      OBJ31-J. Misusing public static variables