Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Parasoft Jtest 2020.2

As suggested by Ware, instances from the class Programs must use the javax.net.ssl.SSLSocket should be created instead of normal Sockets when transferring objects over communication channels. SSLSockets provide a layer of class rather than the java.net.Socket class when transferring sensitive data over insecure communication channels. The class SSLSocket provides security protocols such as SSL or TLS.Secure Sockets Layer/Transport Layer Security (SSL/TLS) to ensure that the channel is not vulnerable to eavesdropping and malicious tampering.

The According to Java API 1.4.2, the principal protections included in SSLSockets SSLSocket that are not provided by the Socket class are [API 2014]:

  • Integrity Protection. : SSL protects against modification of messages by an active wiretapper.
  • Authentication. : In most modes, SSL provides peer authentication. Servers are usually authenticated, and clients may be authenticated as requested by servers.
  • Confidentiality (Privacy Protectionprivacy protection). : In most modes, SSL encrypts data being sent between client and server. This protects the confidentiality of data , so that passive wiretappers won't see sensitive data such as financial information or personal information of many kinds.

It is also important to use SSL for secure remote method invocation (RMI) communications because RMI depends on object serialization, and serialized data must be safeguarded in transit. Gong, Ellison, and Dageforde [Gong 2003] describe how to secure RMI communications using SSLSocket.

Note that this rule lacks any assumptions about the integrity of the data being sent down a socket. For information about ensuring data integrity, see SER02-J. Sign then seal objects before sending them outside a trust boundary.

Noncompliant

...

Code Example

This noncompliant code example shows the use of regular sockets for a server application that fails to protect sensitive information in transit. The insecure code for the corresponding client application follows the server's codeCode for the server side, using Sockets.

Code Block
bgColor#F7D6C1#FFCCCC
  
import java.net.ServerSocket;
import java.net.Socket;
import java.io.*; 

public // Exception handling has been omitted for the sake of brevity
class EchoServer { 
    public static void main(String[] args) throws IOException {
  
  ServerSocket serverSocket = null;
    try {
 
	    ServerSocket serverSocket = new ServerSocket(100079999); 
	      Socket socket = serverSocket.accept();
			
	      PrintWriter out = new PrintWriter( socket.getOutputStream(), true); 
	      BufferedReader in = new BufferedReader(
          new InputStreamReader( socket.getInputStream())); 

	      String inputLine; 

	      while ((inputLine = in.readLine()) != null) { 
	        System.out.println (inputLine); 
	        out.println(inputLine); 
      }
	    } finally {

	      if out.close(); (serverSocket != null) {
  	      in.close(); 
	try {
          socketserverSocket.close();
  
	}
	      } catch (ExceptionIOException ex) { 
	
          //* Handle exception*/
	}error
    
    }
}

Compliant solution

Code for the server side, using SSLSockets.

Code Block

import javax.net.ssl.SSLServerSocket;
import javax.net.ssl.SSLServerSocketFactory;
import javax.net.ssl.SSLSocket;
import java.io.*;

public class EchoServer {
        }
    }
  }
}

class EchoClient {
  public static void main(String[] args) {
        try {
            SSLServerSocketFactory sslserversocketfactory = (SSLServerSocketFactory) SSLServerSocketFactory.getDefault();
 throws UnknownHostException, IOException {
        SSLServerSocket sslserversocketSocket socket = (SSLServerSocket) sslserversocketfactory.createServerSocket(9999)null;
    try {
      socket SSLSocket= sslsocketnew = (SSLSocket) sslserversocket.accept(Socket("localhost", 9999);

            PrintWriter out = new PrintWriter( sslsocketsocket.getOutputStream(), true);
      BufferedReader in = new BufferedReader(
      BufferedReader in = new BufferedReader(new InputStreamReader( sslsocketsocket.getInputStream()));
      BufferedReader stdIn = new   BufferedReader(
            String inputLine; new InputStreamReader(System.in));
            
 String userInput;
  	    while ((inputLineuserInput = instdIn.readLine()) != null) { 
		System.
        out.println (inputLineuserInput); 
		
        System.out.println(inputLinein.readLine());
      } 
	    } finally 
			
	{
      if out.close(); 
	(socket != null) {
        in.close(); 
	try {
          sslsocketsocket.close(); 
        } 
	catch (ExceptionIOException ex) { 
	
          //* Handle exception*/
	} error
        }
      }
    }
  }

Noncompliant code example

}

Note that the sockets are properly closed in accordance with ERR05-J. Do not let checked exceptions escape from a finally block.

Compliant Solution

This compliant solution uses SSLSocket to protect packets using the SSL/TLS security protocols:Code for the client side, using Sockets.

Code Block
bgColor#F7D6C1#CCCCFF
 
import java.io.*;
import java.net.*;

public class EchoClient {
  // Exception handling has been omitted for the sake of brevity
class EchoServer {
  public static void main(String[] args) {
	throws IOException {
    SSLServerSocket sslServerSocket = null;
    try {
  	    SocketSSLServerSocketFactory socketsslServerSocketFactory = new Socket("localhost", 9999);
						
	
          (SSLServerSocketFactory) SSLServerSocketFactory.getDefault();
      sslServerSocket = (SSLServerSocket) sslServerSocketFactory.
                        createServerSocket(9999);
      SSLSocket sslSocket = (SSLSocket) sslServerSocket.accept();
      PrintWriter out = new PrintWriter(socketsslSocket.getOutputStream(), true);
	      BufferedReader in = new BufferedReader(new InputStreamReader(socket.getInputStream()));

	
      BufferedReader stdIn = new BufferedReader(new InputStreamReader(SystemsslSocket.ingetInputStream()));
			
	      String userInputinputLine;

	      while ((userInputinputLine = stdInin.readLine()) != null) {
		 
        System.out.println(userInputinputLine);
		System. 
        out.println(in.readLine(inputLine)); 
	      } 

	    } finally {
      if out.close();
	(sslServerSocket != null) {
         in.close();
	try {
          stdInsslServerSocket.close();
	        socket.close();
	}
	} catch (ExceptionIOException ex) { 
	
          /*/ Handle exception*/
	} 
error
        }
      }
    }

Compliant solution

Code for the client side, using SSLSockets.

Code Block

import javax.net.ssl.SSLSocket;
import javax.net.ssl.SSLSocketFactory;
import java.io.*;

public  }
}

class EchoClient {
    public static void main(String[] args) throws IOException {
    SSLSocket sslSocket = null;
    try {
      SSLSocketFactory sslSocketFactory =
       SSLSocketFactory sslsocketfactory = (SSLSocketFactory) SSLSocketFactory.getDefault();
      sslSocket = 
       SSLSocket sslsocket = (SSLSocket) sslsocketfactorysslSocketFactory.createSocket("localhost", 9999);

  	    PrintWriter out = new PrintWriter(sslsocketsslSocket.getOutputStream(), true);
	      BufferedReader in = new BufferedReader(
          new InputStreamReader(sslsocketsslSocket.getInputStream()));
			
	      BufferedReader stdIn = new BufferedReader(
          new InputStreamReader(System.in));
            
	    String userInput;

	      while ((userInput = stdIn.readLine()) != null) {
		        out.println(userInput);
		        System.out.println(in.readLine());
	      }

	    } finally {
      if out.close();
	(sslSocket != null) {
         in.close();
	try {
      stdIn.close();
	    sslsocketsslSocket.close();		
        } 
	catch (ExceptionIOException ex) { 
	
          /*/ Handle exception*/
	} error
        }
      }
    }
  }
}

References

Programs that use SSLSocket will block indefinitely if they attempt to connect to a port that is not using SSL. Similarly, a program that does not use SSLSocket will block when attempting to establish a connection through a port that does use SSL.

Note that SSLSocket does not validate host names, so providing an arbitrary host name to an SSLSocket is still vulnerable to a man-in-the-middle attack. Host names should be validated separately. The HttpsURLConnection class validates host names and is a suitable solution for secure web sockets.

Exceptions

MSC00-J-EX0: Because of the mechanisms that SSLSocket provides to ensure the secure transfer of packets, significant performance overhead may result. Regular sockets are sufficient under the following circumstances:

  • The data being sent over the socket is not sensitive.
  • The data is sensitive but properly encrypted (see SER02-J. Sign then seal objects before sending them outside a trust boundary for more information).
  • The network path of the socket never crosses a trust boundary. This could happen when, for example, the two endpoints of the socket are within the same local network and the entire network is trusted.

Risk Assessment

Use of plain sockets fails to provide any guarantee of the confidentiality and integrity of data transmitted over those sockets.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

MSC00-J

Medium

Likely

High

P6

L2

Automated Detection

The general case of automated detection appears to be infeasible because determining which specific data may be passed through the socket is not statically computable. An approach that introduces a custom API for passing sensitive data via secure sockets may be feasible. User tagging of sensitive data is a necessary requirement for such an approach.

ToolVersionCheckerDescription
Parasoft Jtest
Include Page
Parasoft_V
Parasoft_V
SECURITY.WSC.USCUse the SSL-enabled version of classes when possible

Related Guidelines

MITRE CWE

CWE-311, Failure to Encrypt Sensitive Data

Bibliography

[API 2014]

Class Socket

[Gong 2003]

Section 11.3.3, "Securing RMI Communications"

[Ware 2008]



...

Image Added Image Added Image AddedTODO