Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Do not send an uncaught signal to kill a thread because the signal kills the entire process, not just the individual thread. This rule is a specific instance of SIG02-C. Avoid using signals to implement normal functionality.Calling the signal() function in a multithreaded program is undefined behavior. (See undefined behavior 135.)

Noncompliant Code Example

This code uses the pthread_killnoncompliant code example invokes the signal() function to send a SIGTERM signal to the created thread. The thread receives the signal, and the entire process is terminated.from a multithreaded program:

Code Block
bgColor#ffcccc
langc
void func(void *foo#include <signal.h>
#include <stddef.h>
#include <threads.h>
 
volatile sig_atomic_t flag = 0;

void handler(int signum) {
  flag = 1;
}

/* Runs until Executionuser ofsends threadSIGUSR1 */
}

int mainfunc(void *data) {
  while int result;(!flag) {
  pthread_t thread;

 /* if ((result = pthread_create(&thread, NULL, func, 0)) != 0... */
  }
  return 0;
}

int main(void) {
  signal(SIGUSR1, handler); /* HandleUndefined Errorbehavior */
  }thrd_t tid;
  
  if ((resultthrd_success != pthreadthrd_kill(threadcreate(&tid, func, SIGTERM)) != 0NULL)) {
    /* Handle Errorerror */
  }

  /* This point is not reached because the process terminates in pthread_kill() */
... */
  return 0;
}

NOTE: The SIGUSR1 signal value is not defined in the C Standard; consequently, this is not a C-compliant code example.

Compliant Solution

This compliant code uses instead the pthread_cancel() function to terminate the thread. The thread continues to run until it reaches a cancellation point. See The Open Group Base Specifications Issue 6, IEEE Std 1003.1, 2004 Edition [Open Group 2004] for lists of functions that are required and allowed to be cancellation points. If the cancellation type is set to asynchronous, the thread is terminated immediately. However, POSIX requires only the pthread_cancel(), pthread_setcancelstate(), and pthread_setcanceltype() functions to be async-cancel safe. An application that calls other POSIX functions with asynchronous cancellation enabled is nonconforming. Consequently, we recommend disallowing asynchronous cancellation, as explained by POS47-C. Do not use threads that can be canceled asynchronously.solution uses an object of type atomic_bool to indicate when the child thread should terminate its loop:

Code Block
bgColor#ccccff
langc
void#include <stdatomic.h>
#include <stdbool.h>
#include <stddef.h>
#include <threads.h>
 
atomic_bool flag = ATOMIC_VAR_INIT(false);

int func(void *foodata) {
  while (!flag) {
    /* ... */
  Execution}
 of threadreturn */0;
}

int main(void) {
  intthrd_t resulttid;
  pthread_t thread;

  if ((resultthrd_success != pthreadthrd_create(&thread, NULLtid, func, 0NULL)) != 0) {
    /* Handle Errorerror */
  }
  if ((result = pthread_cancel(thread)) != 0) {/* ... */
  /* Set /*flag Handlewhen Errordone */
  }

flag  /* Continue executing */= true;

  return 0;
}

Exceptions

CON37-C-EX1: Implementations such as POSIX that provide defined behavior when multithreaded programs use custom signal handlers are exempt from this rule [IEEE Std 1003.1-2013].

Risk Assessment

Sending the signal to a process causes it to be abnormally terminatedMixing signals and threads causes undefined behavior.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

POS44

CON37-C

low

Low

probable

Probable

low

Low

P6

L2

Bibliography

...

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Automated Detection

ToolVersionCheckerDescription
Astrée
Include Page
Astrée_V
Astrée_V
stdlib-use-signalFully checked
CodeSonar
Include Page
CodeSonar_V
CodeSonar_V
BADFUNC.SIGNALUse of signal
Coverity
Include Page
Coverity_V
Coverity_V
MISRA C 2012 Rule 21.5Over-constraining
Cppcheck Premium

Include Page
Cppcheck Premium_V
Cppcheck Premium_V

premium-cert-con37-cFully implemented
Helix QAC

Include Page
Helix QAC_V
Helix QAC_V

C5021

C++5022


Klocwork
Include Page
Klocwork_V
Klocwork_V

MISRA.STDLIB.SIGNAL


LDRA tool suite
Include Page
LDRA_V
LDRA_V
44 SEnhanced enforcement
Parasoft C/C++test
Include Page
Parasoft_V
Parasoft_V

CERT_C-CON37-a

The signal handling facilities of <signal.h> shall not be used
PC-lint Plus

Include Page
PC-lint Plus_V
PC-lint Plus_V

586

Fully supported

Polyspace Bug Finder

Include Page
Polyspace Bug Finder_V
Polyspace Bug Finder_V

CERT C: Rule CON37-CChecks for signal call in multithreaded program (rule fully covered)
RuleChecker
Include Page
RuleChecker_V
RuleChecker_V
stdlib-use-signalFully checked

Bibliography

[IEEE Std 1003.1-2013]XSH 2.9.1, "Thread Safety"


...

Image Modified Image Modified Image Modified