Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Wiki MarkupC99, Section The C Standard, subclause 7.2.1.1 , defines {{[ISO/IEC 9899:2011], defines assert()}} to have the following behavior \[[ISO/IEC 9899:1999|AA. C References#ISO/IEC 9899-1999]\]:

The assert macro puts diagnostic tests into programs; it expands to a void expression. When it is executed, if expression (which shall have a scalar type) is false (that is, compares equal to 0), the assert macro writes information about the particular call that failed (including the text of the argument, the name of the source file, the source line number, and the name of the enclosing function—the latter are respectively the values of the preprocessing pre-processing macros __FILE__ and __LINE__ and of the identifier __func__) on the standard error stream in an implementation-defined format. It then calls the abort function.

Because assert() calls abort(), cleanup functions registered with atexit() are not called. If the intention of the programmer is to properly clean up in the case of a failed assertion, then runtime assertions should be replaced with static assertions where possible. (see See DCL03-C. Use a static assertion to test the value of a constant expression.) . When the assertion is based on runtime data, the assert should be replaced with a runtime check that implements the adopted error strategy (see ERR00-C. Adopt and implement a consistent and comprehensive error-handling policy).

See ERR04-C. Choose an appropriate termination strategy, for more information on program termination strategies and MSC11-C. Incorporate diagnostic tests using assertions, for more information on using the assert() macro.

...

This noncompliant code example defines a function that is called before the program exits to clean up. :

Code Block
bgColor#ffcccc
langc

void cleanup(void) {
  /* Delete temporary files, restore consistent state, etc. */
}

int main(void) {
  if (atexit(cleanup) != 0) {
    /* Handle error */
  }

  /* ... */

  assert(/* somethingSomething bad didn't happen */);

  /* ... */
}

...

In this compliant solution, the call to assert() is replaced with an if statement that calls exit() to ensure that the proper termination routines are run.:

Code Block
bgColor#ccccff
langc

void cleanup(void) {
  /* deleteDelete temporary files, restore consistent state, etc. */
}

int main(void) {
  if (atexit(cleanup) != 0) {
    /* Handle error */
  }

  /* ... */

  if (/* somethingSomething bad happened */) {
    exit(EXIT_FAILURE);
  }

  /* ... */
}

Risk Assessment

Unsafe usage use of abort() may leave files written in an inconsistent state. It may also leave sensitive temporary files on the file system.

Recommendation

Severity

Likelihood

Remediation Cost

Priority

Level

ERR06-C

medium

Medium

unlikely

Unlikely

medium

Medium

P4

L3

Automated Detection

Tool

Version

Checker

Description

Astrée
Include Page
Astrée_V
Astrée_V
bad-function
bad-macro-use
Supported
Compass/ROSE

...



Can detect some violations of this rule. However, it can only detect violations involving abort() because

...

assert()

...

is implemented as a

...

macro

LDRA tool suite
Include Page
LDRA_V
LDRA_V
44 SEnhanced enforcement
Parasoft C/C++test

Include Page
Parasoft_V
Parasoft_V

CERT_C-ERR06-a

Do not use assertions

PC-lint Plus

Include Page
PC-lint Plus_V
PC-lint Plus_V

586

Fully supported

PVS-Studio

Include Page
PVS-Studio_V
PVS-Studio_V

V2021


RuleChecker
Include Page
RuleChecker_V
RuleChecker_V
bad-function
bad-macro-use
Supported

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Other Languages

...

Related Guidelines

...

...

...

ISO/IEC TR 24772:2013Termination Strategy [REU]

Bibliography

References

...

[

...

...

2011]Subclause 7.2.1.1,

...

"The assert Macro"


...

Image Added Image Added {{assert}} macro," and Section 7.20.4.1, "The {{abort}} function" \[[ISO/IEC PDTR 24772|AA. C References#ISO/IEC PDTR 24772]\] "REU Termination Strategy"Image Removed      12. Error Handling (ERR)       Image Modified