Page History

The write() method, defined in the class java.io.OutputStream, takes an argument of type int intended to be between 0 and the value of which must be in the range 0 to 255. Because a value of type int may could be outside this range, failure to range check can result in the truncation of the higher-order bits of the input.unmigrated-wiki-markupargument.

The general contract for the {{write()}} method says that it writes one byte to the output stream. The byte to be written constitutes the eight lower -order bits of the argument {{b}}, passed to the {{write()}} method. The 24 method; the 24 high-order bits of {{b}} are ignored . \[[API 06|AA. Java References#API 06]\](see java.io.OutputStream.write() [API 2014] for more information).

Noncompliant Code Example

This noncompliant code example accepts a value from the user without validating it. Any value that is not in the range of 0 to 255 is truncated. For instance, write(303) prints / on ASCII-based systems because the lower-order 8 bits of 303 are preserved used while the top 24 high-order bits are lost ignored (303 mod % 256 is 47 and / has = 47, which is the ASCII code 47for /). That is, the result is the remainder modulo 256 of the absolute value of the inputinput divided by 256.

class ConsoleWrite {
  public static void main(String[] args) { 
    // Any input value > 255 will result in unexpected output
    System.out.write(Integer.valueOf(args[0].toString()));
    System.out.flush();
  }
}

Compliant Solution

...

(Range-Check Inputs)

This compliant solution prints the corresponding character only if the input integer is in the proper range. If the input is outside the representable range of an int, the Integer.valueOf() method throws a NumberFormatException. If the input can be represented by an int but is outside the range required by write(), this code throws an ArithmeticExceptionUse alternative means to output integers such as the System.out.print* methods.

class ConsoleWriteFileWrite {
  public static void main(String[] args) { 
    System.out.println(args[0]);
  }
}

Compliant Solution (2)

Alternatively, perform range checking to be compliant. While this particular compliant solution still does not display the original out-of-range integer correctly, it behaves well when the corresponding read() method is used to convert the byte value back to a value of type int. This is because it guarantees that the byte variable will contain representable data.

class FileWrite {
  public static void main(String[] args) throws NumberFormatException, IOException { 
    FileOutputStream  out = new FileOutputStream("output");   

throws NumberFormatException, IOException { 
    // Perform range checking  
    if(int value = Integer.valueOf(args[0]);
    if (value < 0 || Integer.valueOf(args[0])value > 255) {
      throw new ArithmeticException("Value is out of range");
    }
  
    System.out.write(Integer.valueOf(args[0].toString()))value);
    System.out.flush(); 
  }
}

Note that a NumberFormatException results when attempting to use the Integer.valueOf() method, if args0 contains a value that is larger than the maximum value of an int.

...

Compliant Solution (writeInt())

This compliant solution uses the writeInt() method of the DataOutputStream class. , which can output the entire range of values representable as an int:

class FileWrite {
  public static void main(String[] args) throws NumberFormatException, IOException { 

                       FileOutputStream out = new FileOutputStream("output");  throws NumberFormatException, IOException { 
    DataOutputStream dos = new DataOutputStream(System.out);
    dos.writeInt(Integer.valueOf(args[0].toString()));
    // close out and dos System.out.flush(); 
  }     
}

Risk Assessment

Using the write() method to output integers may outside the range 0 to 255 will result in unexpected valuestruncation.

Automated Detection

TODO

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

\[[API 06|AA. Java References#API 06]\] method [write()|http://java.sun.com/javase/6/docs/api/java/io/OutputStream.html#write(int)]
\[[Harold 99|AA. Java References#Harold 99]\]

Automated detection of all uses of the write() method is straightforward. Sound determination of whether the truncating behavior is correct is not feasible in the general case. Heuristic checks could be useful.

Related Guidelines

Bibliography

...

Image Added Image Added Image AddedINT01-J. Range check before casting integers to narrower types      06. Integers (INT)      INT06-J. Do not use bitwise operators on integers incorrectly