Page History

A switch statement consists of several case labellabels, plus a default label. The default label is optional , but recommended. (see See MSC01-C. Strive for logical completeness.) . A series of statements following a case label conventionally end ends with a break; statement; if omitted, control flow falls through to the next case in the switch statement block. Since Because the break statement is not required, omitting the break statement it does not produce compiler warnings, and thus can produce diagnostics. If the omission was unintentional, it can result in an unexpected control flow.

Noncompliant Code Example

In this noncompliant code example, the case for when where widget_type is WE_W lacks a break statement. Consequently, the statementsfor statements that should be executed only when widget_type is WE_X get are executed even when widget_type is WE_W.

enum WidgetEnum { WE_W, WE_X, WE_Y, WE_Z } widget_type;
widget_type = WE_X;

switch (widget_type) {
  case WE_W:
    /* ... */
  case WE_X:
    /* ... */
    break;
  case WE_Y: 
  case WE_Z:
    /* ... */
    break;
  default: /* canCan't happen */
	 /* handleHandle error condition */
}

Compliant Solution

In this compliant solution, each sequence of statements following a case label ends with a break statement:

enum WidgetEnum { WE_W, WE_X, WE_Y, WE_Z } widget_type;
widget_type = WE_X;

switch (widget_type) {
  case WE_W:
    /* ... */
    break;
  case WE_X:
    /* ... */
    break;
  case WE_Y: 
  case WE_Z:
    /* ... */
    break;
  default: /* canCan't happen */
	 /* handleHandle error condition */
}

A break statement is not required following the case where widget_type is WE_Y because there are no statements before the next case label, indicating that both WE_Y and WE_Z should be handled in the same fashion.

A break statement is not required following the default case because it would not affect the control flow.

Exceptions

MSC17:-C-EX1: The last label in a switch statement requires no final break. This  It will conventionally be the default label.

MSC17:-C-EX2: When control flow is intended to cross statement labels, it is permissible to omit the break statement. In these instances, the unusual control flow must be explicitly documentedmade clear, such as by adding the [[fallthrough]] C2x attribute, the __attribute__((__fallthrough__)) GNU extension, or a simple comment.

enum WidgetEnum { WE_W, WE_X, WE_Y, WE_Z } widget_type;
widget_type = WE_X;

switch (widget_type) {
  case WE_W:
    /* ... */
    /* noNo break,; fall processthrough caseto forthe WE_X ascase well */
  case WE_X:
    /* ... */
    break;
  case WE_Y: case WE_Z:
    /* ... */
    break;
  default: /* canCan't happen */
	 /* handleHandle error condition */
}

Risk Assessment

Failure to include break statements leads to unexpected control flow.

Automated Detection

Compass/ROSE can detect violations of this recommendation.

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Other Languages

...

Related Guidelines

...

...

...

...

Image Added Image Added Image Added

References

MSC16-C. Consider encrypting function pointers      49. Miscellaneous (MSC)      MSC18-C. Be careful while handling sensitive data (passwords, etc.) in program