Immutable objects should be const
-qualified. Enforcing object immutability using const
qualification helps ensure the correctness and security of applications. ISO/IEC TR 24772, for example, recommends labeling parameters as constant to avoid the unintentional modification of function arguments [ISO/IEC TR 24772]. STR05-C. Use pointers to const when referring to string literals describes a specialized case of this recommendation.
Adding const
qualification may propagate through a program; as you add const
, qualifiers become still more necessary. This phenomenon is sometimes called const
poisoning, which can frequently lead to violations of EXP05-C. Do not cast away a const qualification. Although const
qualification is a good idea, the costs may outweigh the value in the remediation of existing code.
A macro or an enumeration constant may also be used It is preferable to declare immutable values using const
, rather than as macro definitions. Using a const
declared value means that the compiler is able to check the type of the object, the object has scope, and debugging tools will be able to show the name of the object. For integer constants, it is preferable to use an enum
instead of a const
-qualified object as this eliminates the possibility of taking the address of the integer constant and does not required that storage is allocated for the value.
Non-Compliant Code Example 1
. DCL06-C. Use meaningful symbolic constants to represent literal values describes the relative merits of using const
-qualified objects, enumeration constants, and object-like macros. However, adding a const
qualifier to an existing variable is a better first step than replacing the variable with an enumeration constant or macro because the compiler will issue warnings on any code that changes your const
-qualified variable. Once you have verified that a const
-qualified variable is not changed by any code, you may consider changing it to an enumeration constant or macro, as best fits your design.
Noncompliant Code Example
In this noncompliant code, pi
is declared as a float
. Although pi is a mathematical constant, its value is not protected from accidental modificationIn this example, PI
is defined using a macro. In the code, the value is introduced by textual subsitution.
Code Block | ||||
---|---|---|---|---|
| ||||
float pi = #define PI 3.14159 ... 14159f; float degrees; float radians; /* ... */ radians = degrees *PI pi / 180; |
Compliant Solution
...
In this compliant solution, the constant pi
is defined declared as a const
variable.-qualified object:
Code Block | ||||
---|---|---|---|---|
| ||||
const float const pi = 3.1415914159f; ... float degrees; float radians; /* ... */ radians = degrees * pi / 180; |
Non-Compliant Code Example 2
In this example, an integer value is defined using a macro.
Code Block | ||
---|---|---|
| ||
#define MAX 42
...
for (int i = 0; i < max; ++i) {
...
}
|
Compliant Solution 2
This compliant solution uses an enum
rather than a macro definition.
Code Block | ||
---|---|---|
| ||
int const max = 42;
...
for (int i = 0; i < MAX; ++i) {
...
}
|
Exceptions
Values declared using const
cannot be used where compile-time constants are required. So, a const-qualified value cannot be used to specify the
- size of a bit-field member of a structure
- size of an array
- value of an enumeration constant
- value of a
case
constant.
If any of these are required, then an enum
or a macro definition must be used.
Risk Assessment
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
DCL00-A | 1 (low) | 1 (unlikely) | 2 (medium) | P2 | L3 |
References
Risk Assessment
Failing to const
-qualify immutable objects can result in a constant being modified at runtime.
Recommendation | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
DCL00-C | Low | Unlikely | High | P1 | L3 |
Automated Detection
Tool | Version | Checker | Description | ||||||
---|---|---|---|---|---|---|---|---|---|
Astrée |
| parameter-missing-const | Partially checked | ||||||
Axivion Bauhaus Suite |
| CertC-DCL00 | |||||||
CodeSonar |
| LANG.CAST.PC.CRCQ LANG.TYPE.VCBC LANG.STRUCT.RPNTC | Cast removes const qualifier Variable Could Be const Returned Pointer Not Treated as const | ||||||
Compass/ROSE | |||||||||
| CC2.DCL00 | Partially implemented | |||||||
Helix QAC |
| C3204, C3227, C3232, C3673, C3677 | |||||||
LDRA tool suite |
| 78 D | Fully implemented | ||||||
Parasoft C/C++test |
| CERT_C-DCL00-a | Declare local variable as const whenever possible | ||||||
PC-lint Plus |
| 953 | Fully supported | ||||||
Polyspace Bug Finder |
| CERT C: DCL00-C | Checks for unmodified variable not const-qualified (rule fully covered). | ||||||
RuleChecker |
| parameter-missing-const | Partially checked |
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
Related Guidelines
Bibliography
[Dewhurst 2002] | Gotcha #25, "#define Literals" |
[Saks 2000] |
...
...