The only unsigned primitive integer type in Java is the 16-bit char
data type; all of the other primitive integer types are signed. To interoperate with native languages, such as C or C++, that use unsigned types extensively, read any unsigned values into the next larger Java signed primitive integer typemust be read and stored into a Java integer type that can fully represent the possible range of the unsigned data. For example, use a long
to hold an the Java long
type can be used to represent all possible unsigned 32-bit integer value values obtained from native code.
Noncompliant Code Example
This noncompliant code example uses a generic method for reading in integer data without considering the signedness of the source. It assumes that the values data read are is always signed and treats the most significant bit as the sign bit. When the data being read is unsigned, this causes misinterpretations of the actual sign and magnitude of the valuevalues may be misinterpreted.
Code Block | ||
---|---|---|
| ||
public static int getInteger(DataInputStream is) throws IOException {
return is.readInt();
}
|
Compliant Solution
This compliant solution assumes requires that the values being read are 32-bit unsigned integers. It reads an unsigned integer value into a long
variable using the readInt()
method. The readInt()
method assumes signed values and returns a signed Java int
; the return value is converted to a long
with sign extension. The code uses an &
operation to mask off the upper 32 - bits of the long
; this produces , producing a value in the range of a 32-bit unsigned integer, as intended. The mask size should be chosen to match the size of the unsigned integer values being read.
Code Block | ||
---|---|---|
| ||
public static long getInteger(DataInputStream is) throws IOException { return is.readInt() & 0xFFFFFFFFL; // maskMask with 32 one-bits } |
As a general ruleprinciple, you must should always be aware of the signedness of the data you are reading.
Risk Assessment
Treating unsigned data as though it were signed will produce produces incorrect values and can lead to lost or misinterpreted data.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|
NUM03-J |
Low |
Unlikely |
Medium | P2 | L3 |
Automated Detection
Automated detection is infeasible in the general case.
Bibliography
...
] | Class |
]]></ac:plain-text-body></ac:structured-macro>
] | Chapter 2 |
, "Primitive Data Types, Cross-Platform Issues, Unsigned Integers |
]]></ac:plain-text-body></ac:structured-macro>
" |
[ |
] |
Section 2.4.5, "Accessing Unsigned Data" |
]]></ac:plain-text-body></ac:structured-macro>
[Seacord 2015] |
...
NUM02-J. Use shift operators correctly 03. Numeric Types and Operations (NUM) NUM04-J. Avoid using floating-point numbers when precise computation is required