Page History

One way to order objects of a class relative to one another is to implement the Comparable interfaceChoosing to implement the Comparable interface represents a commitment that the implementation of the compareTo() method adheres to the general contract for that method regarding how the method is to be called. Library classes such as TreeSet and TreeMap accept Comparable objects and use their the associated compareTo() methods to sort themthe objects. However, a class that implements the compareTo() method in an unexpected way can cause undesirable results.

Wiki MarkupThe general usage contract for {{compareTo()}} from Java SE 6 8 API \ [[API 06|AA. Java References#API 06]\] states that:API 2014] states that

1. The implementor must ensure sgn(x.compareTo(y)) == -sgn(y.compareTo(x)) for all x and y. (This implies that x.compareTo(y) must throw an exception

iff

1. if y.compareTo(x) throws an exception.)
2. The implementor must also ensure that the relation is transitive: (x.compareTo(y)

>0

1. > 0 && y.compareTo(z)

>0

1. > 0) implies x.compareTo(z)

>0

1. > 0.
2. Finally, the implementor must ensure that x.compareTo(y) == 0 implies that sgn(x.compareTo(z)) == sgn(y.compareTo(z))

,

1. for all z.
2. It is strongly recommended, but not strictly required, that (x.compareTo(y) == 0) ==

(

1. x.equals(y)

)

1. . Generally speaking, any class that implements the Comparable interface and violates this condition should clearly indicate this fact. The recommended language is

"

1. Note: this class has a natural ordering that is inconsistent with equals.

"

In the foregoing description, the notation sgn(expression) designates the mathematical signum function, which is defined to return either -1, 0, or 1 depending on whether the value of the expression is negative, zero or positive.

Do not Implementations must never violate any of the first three conditions when implementing the compareTo() method. Implementing Implementations should conform to the fourth condition is strongly recommended but is not necessarywhenever possible.

Noncompliant Code Example

...

(Rock-Paper-Scissors)

This program implements the classic game of rock-paper-scissors, using the compareTo() operator to determine the winner of a game:This noncompliant code example violates the third condition (transitivity) in the contract. This requirement states that the objects that compareTo() considers equal (by returning 0) must be ordered the same with respect to other objects. For example, a card may require to be compared against any other card to check whether both belong to the same suit or have the same rank. If neither of these conditions is true, compareTo() is expected to order the cards based on rank alone. This situation may arise in a game like Uno or Crazy Eights, where one can only place a card on the pile that shares a suit or rank with the top most card on the pile.

public final class CardGameEntry implements Comparable {
  public  private String suit;enum Roshambo {ROCK, PAPER, SCISSORS}
  private intRoshambo rankvalue;

  public CardGameEntry(String s, int rRoshambo value) {
    if (s == null) {
      throw new NullPointerException();
    }
    suit = s;
    rank = r;
  }

  public boolean equals(Object othis.value = value;
  }

  public int compareTo(Object that) {
    if (o!(that instanceof CardGameEntry)) {
      Cardthrow c = (Card)o;
      return suit.equals(c.suit) || (rank == c.rank); // Badnew ClassCastException();
    }
    returnGameEntry false;
  }

  // This method violates its contract
  public int compareTo(Object o) {t = (GameEntry) that;
    ifreturn (ovalue instanceof Card== t.value) {? 0
      Card: c(value = (Card)o;
      if(suit.equals(c.suit) ) = Roshambo.ROCK && t.value == Roshambo.PAPER) ? -1
        return 0;
      if((c.rank >= rank + Integer.MIN_VALUE) && 
          (c.rank <= rank + Integer.MAX_VALUE) )
        // Check for integer overflow
        return c.rank - rank; // Order based on rank
    }
    throw new ClassCastException();
  }

  public static void main(String[] args) {
    Card a = new Card("Clubs", 2);
    Card b = new Card("Clubs", 10);
    Card c = new Card("Hearts", 7);
    System.out.println(a.compareTo(b)); // Returns 0
    System.out.println(a.compareTo(c)); // Returns a negative number
    System.out.println(b.compareTo(c)); // Returns a positive number: (value == Roshambo.PAPER && t.value == Roshambo.SCISSORS) ? -1
      : (value == Roshambo.SCISSORS && t.value == Roshambo.ROCK) ? -1
      : 1;
  }
}

Here, the comparison between (a,c) yields that c is larger. However, the comparison (b,c) yields b as larger. This means b must be larger than a. However, comparing (a,b) results in the value 0 implying that both a and b compare equal.

Compliant Solution

this game violates the required transitivity property because rock beats scissors, scissors beats paper, but rock does not beat paper.

Compliant Solution (Rock-Paper-Scissors)

This compliant solution implements the same game without using the Comparable interface:This compliant solution ensures that the compareTo() contract is satisfied, and the corresponding equals() method is consistent with compareTo().

publicclass finalGameEntry class{
 Card implementspublic Comparable{
enum Roshambo private String suit;{ROCK, PAPER, SCISSORS}
  private intRoshambo rankvalue;

  public CardGameEntry(String s, int rRoshambo value) {
    if (s == null) {
      throw new NullPointerException();
    }
    suit = s;
    rank = rthis.value = value;
  }

  public booleanint equalsbeats(Object othat) {
    if (o!(that instanceof CardGameEntry)) {
      Card c=(Card)o;
      return suit.equals(c.suit) && (rank == c.rank); // Goodthrow new ClassCastException();
    }
    returnGameEntry false;
  }

  // This method fulfills its contract
  public int compareTo(Object o) {t = (GameEntry) that;
    ifreturn (o instanceof Card) {
      Card c=(Card)o;
      if(suit.equals(c.suit) &&value == t.value) ? 0
         : (c.rankvalue >== rank + Integer.MIN_VALUE)Roshambo.ROCK &&
          (c.rank <= rank + Integer.MAX_VALUE) )  t.value == Roshambo.PAPER) ? -1
      : (value return== cRoshambo.rankPAPER - rank;
      return suit.compareTo(c.suit);
    }&& t.value == Roshambo.SCISSORS) ? -1
    throw new ClassCastException();
  }

  public static void main(String[] args) {
    Card a = new Card("Clubs", 2);
    Card b = new Card("Clubs", 10);
    Card c = new Card("Hearts", 7);
    System.out.println(a.compareTo(b)); // Returns 0
    System.out.println(a.compareTo(c)); // Returns a negative number
    System.out.println(b.compareTo(c)); // Returns a negative number : (value == Roshambo.SCISSORS && t.value == Roshambo.ROCK) ? -1
      : 1;
  }
}

As required by the ordering, c is larger than both a and b and the comparison (a,b) produces an equal result. This maintains the compareTo() method's contract.

Risk Assessment

Violating the general contract when implementing the compareTo() method can result in cause unexpected results, possibly leading to invalid comparisons and information disclosure.

Automated Detection

...

Automated detections of violations of this rule is infeasible in the general case.

Tool	Version	Checker	Description
CodeSonar	Include Page CodeSonar_V CodeSonar_V	JAVA.CLASS.MCS	Missing Call to super (Java)
Coverity	7.5	FB.RU_INVOKE_RUN	Implemented

Related Guidelines

Bibliography

...

Image Added Image Added Image Added

The Coverity Prevent Version 5.0 MUTABLE_COMPARISON checker can detect the instances where compareTo method is reading from a non constant field. If the non-constant field is modified, the value of compareTo might change, which may break program invariants.

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Other Languages

This rule appears in the C++ Secure Coding Standard as ARR40-CPP. Use a Valid Ordering Rule.

References

\[[API 06|AA. Java References#API 06]\] method [compareTo()|http://java.sun.com/javase/6/docs/api/java/lang/Comparable.html#compareTo(java.lang.Object)]
\[[JLS 05|AA. Java References#JLS 05]\]

MET13-J. Ensure that hashCode() is overridden when equals() is overridden      12. Methods (MET)      MET15-J. Do not use deprecated or obsolete methods