Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Paragraph 15 further states (nonnormative text removed for brevity) the following:

Except where noted, evaluations of operands of individual operators and of subexpressions of individual expressions are unsequenced. ... The value computations of the operands of an operator are sequenced before the value computation of the result of the operator. If a side effect on a scalar object is unsequenced relative to either another side effect on the same scalar object or a value computation using the value of the same scalar object, and they are not potentially concurrent, the behavior is undefined. ... When calling a function (whether or not the function is inline), every value computation and side effect associated with any argument expression, or with the postfix expression designating the called function, is sequenced before execution of every expression or statement in the body of the called function. ... Every evaluation in the calling function (including other function calls) that is not otherwise specifically sequenced before or after the execution of the body of the called function is indeterminately sequenced with respect to the execution of the called function. Several contexts in C++ cause evaluation of a function call, even though no corresponding function call syntax appears in the translation unit. ... The sequencing constraints on the execution of the called function (as described above) are features of the function calls as evaluated, whatever the syntax of the expression that calls the function might be.

...

  • In postfix ++ and -- expressions, the value computation is sequenced before the modification of the operand. ([expr.post.incr], paragraph 1)
  • In logical && expressions, if the second expression is evaluated, every value computation and side effect associated with the first expression is sequenced before every value computation and side effect associated with the second expression. ([expr.log.and], paragraph 2)
  • In logical || expressions, if the second expression is evaluated, every value computation and side effect associated with the first expression is sequenced before every value computation and side effect associated with the second expression. ([expr.log.or], paragraph 2)
  • In conditional ?: expressions, every value computation and side effect associated with the first expression is sequenced before every value computation and side effect associated with the second or third expression (whichever is evaluated). ([expr.cond], paragraph 1)
  • In assignment expressions (including compound assignments), the assignment is sequenced after the value computations of left and right operands , and before the value computation of the assignment expression. ([expr.ass], paragraph 1)
  • In comma , expressions, every value computation and side effect associated with the left expression is sequenced before every value computation and side effect associated with the right expression. ([expr.comma], paragraph 1)
  • When evaluating initializer lists, the value computation and side effect associated with each initializer-clause is sequenced before every value computation and side effect associated with a subsequent initializer-clause. ([dcl.init.list], paragraph 4)
  • When a signal handler is executed as a result of a call to std::raise(), the execution of the handler is sequenced after the invocation of std::raise() and before its return. ([intro.execution], paragraph 6)
  • The completions of the destructors for all initialized objects with thread storage duration within a thread are sequenced before the initiation of the destructors of any object with static storage duration. ([basic.start.term], paragraph 1)
  • In a new-expression, initialization of an allocated object is sequenced before the value computation of the new-expression. ([expr.new], paragraph 18)
  • When a default constructor is called to initialize an element of an array and the constructor has at least one default argument, the destruction of every temporary created in a default argument is sequenced before the construction of the next array element, if any. ([class.temporary], paragraph 4)
  • The destruction of a temporary whose lifetime is not extended by being bound to a reference is sequenced before the destruction of every temporary which that is constructed earlier in the same full-expression. ([class.temporary], paragraph 5)
  • Atomic memory ordering functions can explicitly determine the sequencing order for expressions. ([atomics.order] and [atomics.fences])

...

have defined behavior, and statements such as the following do not:.

Code Block
bgColor#FFcccc
langcpp
// i is modified twice in the same full expression
i = ++i + 1;  

// i is read other than to determine the value to be stored
a[i++] = i;   

Not all instances of a comma in C++ code denote a usage use of the comma operator. For example, the comma between arguments in a function call is not the comma operator. Additionally, overloaded operators behave the same as a function call, with the operands to the operator acting as arguments to a function call.

...

In this noncompliant code example, i is evaluated more than once in an unsequenced manner, and so the behavior of the expression is undefined:.

Code Block
bgColor#FFcccc
langcpp
void f(int i, const int *b) {
  int a = i + b[++i];
  // ...
}

...

These examples are independent of the order of evaluation of the operands and can each be interpreted in only one way:.

Code Block
bgColor#ccccff
langcpp
void f(int i, const int *b) {
  ++i;
  int a = i + b[i];
  // ...
}

...

Code Block
bgColor#ccccff
langcpp
void f(int i, const int *b) {
  int a = i + b[i + 1];
  ++i;
  // ...
}

...

The call to func() in this noncompliant code example has undefined behavior because the argument expressions are unsequenced:.

Code Block
bgColor#FFcccc
langcpp
extern void func(int i, int j);
 
void f(int i) {
  func(i++, i);
}

...

This compliant solution is appropriate when the programmer intends for both arguments to func() to be equivalent:.

Code Block
bgColor#ccccff
langcpp
extern void func(int i, int j);
 
void f(int i) {
  i++;
  func(i, i);
}

This compliant solution is appropriate when the programmer intends for the second argument to be 1 greater than the first:.

Code Block
bgColor#ccccff
langcpp
extern void func(int i, int j);
 
void f(int i) {
  int j = i++;
  func(j, i);
}

...

The order of evaluation for function arguments is unspecified. This noncompliant code example exhibits unspecified behavior but not undefined behavior:.

Code Block
bgColor#FFcccc
langcpp
extern void c(int i, int j);
int glob;
 
int a() {
  return glob + 10;
}

int b() {
  glob = 42;
  return glob;
}
 
void f() {
  c(a(), b());
}

...

In this compliant solution, the order of evaluation for a() and b() is fixed, and so no unspecified behavior occurs:.

Code Block
bgColor#ccccff
langcpp
extern void c(int i, int j);
int glob;
 
int a() {
  return glob + 10;
}
 
int b() {
  glob = 42;
  return glob;
}
 
void f() {
  int a_val, b_val;
 
  a_val = a();
  b_val = b();

  c(a_val, b_val);
}

...

Attempting to modify an object in an unsequenced or indeterminately sequenced evaluation may cause that object to take on an unexpected value, which can lead to unexpected program behavior.

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

EXP50-CPP

Medium

Probable

Medium

P8

L2

Automated Detection

Tool

Version

Checker

Description

Axivion Bauhaus Suite

Include Page
Axivion Bauhaus Suite_V
Axivion Bauhaus Suite_V

CertC++-EXP50
Clang
Include Page
Clang_V
Clang_V
-WunsequencedCan detect simple violations of this rule where path-sensitive analysis is not required

Compass/ROSE

 

CodeSonar
Include Page
CodeSonar_V
CodeSonar_V

LANG.STRUCT.SE.DEC
LANG.STRUCT.SE.INC

Side Effects in Expression with Decrement
Side Effects in Expression with Increment

Compass/ROSE
 



Can detect simple violations of this rule. It needs to examine each expression and make sure that no variable is modified twice in the expression. It also must check that no variable is modified once, then read elsewhere, with the single exception that a variable may appear on both the left and right of an assignment operator

Coverity

Include Page
Coverity_V
Coverity_V

EVALUATION_ORDER

Can detect the specific instance where a statement contains multiple side effects on the same value with an undefined evaluation order because, with different compiler flags or different compilers or platforms, the statement may behave differently

ECLAIR

Include Page
ECLAIR_V
ECLAIR_V

CC2.EXP30

Fully implemented

GCC
Include Page
GCC_V
GCC_V
 


Can detect violations of this rule when the -Wsequence-point flag is used

LDRA tool suite
Helix QAC

Include Page

LDRA

Helix QAC_V

LDRA

Helix QAC_V

35 D, 1 Q, 9 S, 134 S, 67 D, 72 D

Partially implemented

Parasoft C/C++test9.5JSF-204.1{a,b,c,d,g}Fully implementedPRQA QA-C++ Include PagePRQA QA-C++_VPRQA QA-C++_V3220, 3221, 3222, 3223 

C++3220, C++3221, C++3222, C++3223, C++3228


Klocwork
Include Page
Klocwork_V
Klocwork_V
PORTING.VAR.EFFECTS
CERT.EXPR.PARENS
MISRA.EXPR.PARENS.INSUFFICIENT
MISRA.INCR_DECR.OTHER

LDRA tool suite
Include Page
LDRA_V
LDRA_V

35 D, 1 Q, 9 S, 134 S, 67 D, 72 D

Partially implemented

Parasoft C/C++test
Include Page
Parasoft_V
Parasoft_V

CERT_CPP-EXP50-a
CERT_CPP-EXP50-b
CERT_CPP-EXP50-c
CERT_CPP-EXP50-d
CERT_CPP-EXP50-e
CERT_CPP-EXP50-f

The value of an expression shall be the same under any order of evaluation that the standard permits
Don't write code that depends on the order of evaluation of function arguments
Don't write code that depends on the order of evaluation of function designator and function arguments
Don't write code that depends on the order of evaluation of expression that involves a function call
Between sequence points an object shall have its stored value modified at most once by the evaluation of an expression
Don't write code that depends on the order of evaluation of function calls

Polyspace Bug Finder

Include Page
Polyspace Bug Finder_V
Polyspace Bug Finder_V

CERT C++: EXP50-CPPChecks for situations where expression value depends on order of evaluation (rule fully covered).
PVS-Studio

Include Page
PVS-Studio_V
PVS-Studio_V

V521, V708
SonarQube C/C++ Plugin
Include Page
SonarQube C/C++ Plugin_V
SonarQube C/C++ Plugin_V
IncAndDecMixedWithOtherOperatorsPartially implemented
Splint
Include Page
Splint_V
Splint_V

 

 



Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

Bibliography

[ISO/IEC 14882-2014]Subclause 1.9, "Program Execution"
[MISRA
08
2008]Rule 5-0-1 (Required)

...


...

Image Modified Image Modified Image Modified