Page History

...

Noncompliant Code Example

The following This noncompliant code example simply shows the standard string-handling function strlen() being called with a plain character string, a signed character string, and an unsigned character string. The strlen() function takes a single argument of type const char *.:

size_t len;
char cstr[] = "char string";
signed char scstr[] = "signed char string";
unsigned char ucstr[] = "unsigned char string";

len = strlen(cstr);
len = strlen(scstr);  /* warnsWarns when char is unsigned */
len = strlen(ucstr);  /* warnsWarns when char is signed */

Compiling at high warning levels in compliance with MSC00-C. Compile cleanly at high warning levels causes warnings to be issued when

• converting Converting from unsigned char[] to const char * when char is signed.
• converting Converting from signed char[] to const char * when char is defined to be unsigned.

Casts are required to eliminate these warnings, but excessive casts can make code difficult to read and hide legitimate warning messages.

...

The compliant solution uses plain char for character data.:

size_t len;
char cstr[] = "char string";

len = strlen(cstr);

...

Failing to use plain char for characters in the basic character set can lead to excessive casts and less effective compiler diagnostics.

Automated Detection

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

...

Image Modified Image Modified Image Modified