Immutable objects should be {{ Wiki Markup const
}}\-qualified. Enforcing object immutability using {{const
}}\- qualification helps ensures ensure the correctness and security of applications. ISO/IEC PDTR 24772 \[[ISO/IEC PDTR 24772|AA. C References#ISO/IEC PDTR 24772]\], for example, recommends labeling parameters as constant to avoid the unintentional modification of function arguments. [STR05-A. Use pointers to const when referring to string literals] describes a specialized case of this recommendation. TR 24772, for example, recommends labeling parameters as constant to avoid the unintentional modification of function arguments [ISO/IEC TR 24772]. STR05-C. Use pointers to const when referring to string literals describes a specialized case of this recommendation.
Adding const
qualification may propagate through a program; as you add const
, qualifiers , become still more become necessary. This phenomenon is sometimes called "const
-poisoning." Const-poisoning poisoning, which can frequently lead to violations of EXP05-AC. Do not cast away a const qualification. While Although const
qualification is a good idea, the costs may outweigh the value in the remediation of existing code.
One may wish to consider using a macro, A macro or an enumeration constant , rather than a const
variable, see DCL06-Amay also be used instead of a const
-qualified object. DCL06-C. Use meaningful symbolic constants to represent literal values in program logic for details regarding macros vs. enumeration constants vs. const
variables describes the relative merits of using const
-qualified objects, enumeration constants, and object-like macros. However, adding a const
qualifier to a pre-an existing variable is a better first step than replacing the variable with an enumeration constant or macro , because the compiler can then will issue warnings on any code that changes your const
-qualified variable. Once you have verified that a const
-qualified variable indeed is not changed by any code, you may then consider changing it to an enumeration constant or macro, as best fits your design.
...
Noncompliant Code Example
In this non-compliant noncompliant code example, pi
is declared as a float
. Although pi is a mathematical constant, its value is not protected from accidental modification.
Code Block | ||||
---|---|---|---|---|
| ||||
float pi = 3.14159f;
float degrees;
float radians;
/* ... */
radians = degrees * pi / 180;
|
Compliant Solution
In this compliant solution, pi
is declared as a const
-qualified object.:
Code Block | ||||
---|---|---|---|---|
| ||||
const float pi = 3.14159f;
float degrees;
float radians;
/* ... */
radians = degrees * pi / 180;
|
Risk Assessment
Failing to const
-qualify immutable objects can result in a constant being modified at runtime.
Recommendation | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
DCL00- |
1 (low)
1 (unlikely)
1 (high)
P1
C | Low | Unlikely | High | P1 | L3 |
Automated Detection
Tool | Version | Checker | Description | ||||||
---|---|---|---|---|---|---|---|---|---|
Astrée |
| parameter-missing-const | Partially checked | ||||||
Axivion Bauhaus Suite |
| CertC-DCL00 | |||||||
CodeSonar |
| LANG.CAST.PC.CRCQ LANG.TYPE.VCBC LANG.STRUCT.RPNTC | Cast removes const qualifier Variable Could Be const Returned Pointer Not Treated as const | ||||||
Compass/ROSE | |||||||||
| CC2.DCL00 | Partially implemented | |||||||
Helix QAC |
| C3204, C3227, C3232, C3673, C3677 | |||||||
LDRA tool suite |
| 78 D | Fully implemented | ||||||
Parasoft C/C++test |
| CERT_C-DCL00-a | Declare local variable as const whenever possible | ||||||
PC-lint Plus |
| 953 | Fully supported | ||||||
Polyspace Bug Finder |
| CERT C: DCL00-C | Checks for unmodified variable not const-qualified (rule fully covered). | ||||||
RuleChecker |
| parameter-missing-const | Partially checked |
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERT website.
References
Wiki Markup |
---|
\[[ISO/IEC 9899-1999|AA. C References#ISO/IEC 9899-1999]\] Section 6.7.3, "Type qualifiers"
\[[Saks 00|AA. C References#Saks 00]\] Dan Saks. [Numeric Literals|http://www.embedded.com/2000/0009/0009pp.htm]. Embedded Systems Programming. September, 2000. |
Related Guidelines
Bibliography
[Dewhurst 2002] | Gotcha #25, "#define Literals" |
[Saks 2000] |
...
02. Declarations and Initialization (DCL) 02. Declarations and Initialization (DCL) DCL01-A. Do not reuse variable names in subscopes