Page History

Wiki Markup Sensitive data must be protected from eavesdropping and malicious tampering. An obfuscated transfer object \[[Steel 2005|AA. Bibliography#Steel 05]\] that is strongly encrypted can protect data. This approach is known as _sealing_ the object. To guarantee object integrity, apply a digital signature to the sealed object. eavesdropping. All data that crosses a trust boundary must be protected from malicious tampering. An obfuscated transfer object [Steel 2005] that is strongly encrypted can protect data. This approach is known as sealing the object. To guarantee object integrity, apply a digital signature to the sealed object.

Sealing and signing objects is the preferred mechanism to secure data when

• Serializing or transporting sensitive dataTransporting sensitive data or serializing any data.
• A secure communication channel such as Secure Sockets Layer (SSL) is absent or is too costly for limited transactions.
• Sensitive data must persist over an extended period of time (for example, on a hard drive).

Avoid using home-brewed cryptographic algorithms; such algorithms will almost certainly introduce unnecessary vulnerabilities. Applications that apply home-brewed "cryptography" in the readObject() and writeObject() methods are prime examples of anti-patterns. However, using existing cryptography libraries inside readObject() and writeObject() is perfrectly warranted.

This rule applies to the intentional serialization This rule applies to the intentional serialization of sensitive information. Rule SER03-J. Do not serialize unencrypted , sensitive data is meant to prevent the unintentional serialization of sensitive information.

Noncompliant Code Example

Code The code examples for this rule are all based upon on the following code example. :

class SerializableMap<K,V> implements Serializable {
  final static long serialVersionUID = -2648720192864531932L;
  private Map<K,V> map;
  
  public SerializableMap() {
    map = new HashMap<K,V>();
  }

  public Object getData(K key)  {
    return map.get(key);
  }

  public void setData(K key, V data)  {
    map.put(key, data);
  }
}

public class MapSerializer {
  public static SerializableMap<String, Integer> buildMap() {
    SerializableMap<String, Integer> map = 
        new SerializableMap<String, Integer>();
    map.setData("John Doe", new Integer(123456789));
    map.setData("Richard Roe", new Integer(246813579));
    return map;
  }

  public static void InspectMap(SerializableMap<String, Integer> map) {
    System.out.println("John Doe's number is " + map.getData("John Doe"));
    System.out.println("Richard Roe's number is " + map.getData("Richard Roe"));
  }

  public static void main(
                       map.getData("Richard Roe"));
  }

  public static void main(String[] args) {
    // ...
  }
}

...

This noncompliant code example simply serializes then deserializes the map and then deserializes it. Consequently, the map is capable of being can be serialized and transferred across different business tiers. Unfortunately, there are no the example lacks any safeguards against byte stream manipulation attacks while the binary data is in transit. Likewise, anyone can reverse-engineer the serialized stream data from its hexadecimal notation to reveal to recover the data in the HashMap. Anyone would also be able to tamper with the map and produce an object that made the deserializer crash or hang.

public static void main(String[] args)
                        throws IOException, ClassNotFoundException {
  // Build map
  SerializableMap<String, Integer> map = buildMap();

  // Serialize map
  ObjectOutputStream out =
      new ObjectOutputStream(new FileOutputStream("data"));
  out.writeObject(map);
  out.close();

  // Deserialize map
  ObjectInputStream in =
 new     new ObjectInputStream(new FileInputStream("data"));
  map = (SerializableMap<String, Integer>) in.readObject();
  in.close();

  // Inspect map
  InspectMap(map);
}

If the data in the map is considered were sensitive, this example will would also violate SER03-J. Do not serialize unencrypted , sensitive data.

Noncompliant Code Example (Seal)

This noncompliant code example uses the javax.crypto.SealedObject class to provide message confidentiality. This class encapsulates a serialized object and encrypts (or seals) it. A strong cryptographic algorithm that uses a secure cryptographic key and padding scheme must be employed to initialize the Cipher object parameter. The seal() and unseal() utility methods provide the encryption and decryption facilities respectively.

This noncompliant code example encrypts the map into a SealedObject, rendering the data inaccessible to prying eyes. However, because the program fails to sign the data is not signed, it provides no proof of authenticationrendering it impossible to authenticate.

public static void main(String[] args)
  throws IOException, GeneralSecurityException, ClassNotFoundException {
  // Build map
  SerializableMap<String, Integer> map = buildMap();

  // Generate sealing key & seal map
throws IOException, KeyGeneratorGeneralSecurityException, generator;
   generator = KeyGenerator.getInstance("AES");
  generator.init(new SecureRandom());
  Key key = generator.generateKey();
  Cipher cipher = Cipher.getInstance("AES");
  cipher.init(Cipher.ENCRYPT_MODE, key);
  SealedObject sealedMap = new SealedObject(map, cipher);

             ClassNotFoundException {
  // SerializeBuild map
  SerializableMap<String, ObjectOutputStreamInteger> outmap = new ObjectOutputStream(new FileOutputStream("data")buildMap();

  out.writeObject(sealedMap);
  out.close();

  // Deserialize// Generate sealing key & seal map
  ObjectInputStreamKeyGenerator ingenerator;
 = newgenerator ObjectInputStream(new FileInputStream= KeyGenerator.getInstance("dataAES"));
  sealedMap = (SealedObject) in.readObject(generator.init(new SecureRandom());
   in.closeKey key = generator.generateKey();

  // Unseal map
  Cipher cipher = Cipher.getInstance("AES");
  cipher.init(Cipher.DECRYPTENCRYPT_MODE, key);
  SealedObject mapsealedMap = new SealedObject(SerializableMap<Stringmap, Integer>) sealedMap.getObject(cipher);

  // InspectSerialize map
  ObjectOutputStream out =
      new InspectMap(map);
}

Noncompliant Code Example (Seal then Sign)

This noncompliant code example uses the java.security.SignedObject class to sign an object, when the integrity of the object is to be ensured. The two new arguments passed in to the SignedObject() method to sign the object are Signature and a private key derived from a KeyPair object. To verify the signature, a PublicKey as well as a Signature argument is passed to the SignedObject.verify() method.

This noncompliant code example signs the object as well as seals it. According to Abadi and Needham \[[Abadi 1996|AA. Bibliography#Abadi 96]\]

When a principal signs material that has already been encrypted, it should not be inferred that the principal knows the content of the message. On the other hand, it is proper to infer that the principal that signs a message and then encrypts it for privacy knows the content of the message.

The rationale is that any malicious party can intercept the originally signed encrypted message from the originator, strip the signature and add its own signature to the encrypted message. Both the malicious party, and the receiver have no information about the contents of the original message as it is encrypted and then signed (it can only be decrypted after verifying the signature). The receiver has no way of confirming the sender's identity unless the legitimate sender's public key is obtained over a secure channel. One of the three CCITT X.509 standard protocols was susceptible to such an attack \[[CCITT 1988|AA. Bibliography#CCITT 88]\].  

Because the signing occurs after the sealing it cannot be assumed that the signer is the true originator of the object.

ObjectOutputStream(new FileOutputStream("data"));
  out.writeObject(sealedMap);
  out.close();

  // Deserialize map
  ObjectInputStream in =
      new ObjectInputStream(new FileInputStream("data"));
  sealedMap = (SealedObject) in.readObject();
  in.close();

  // Unseal map
  cipher = Cipher.getInstance("AES");
  cipher.init(Cipher.DECRYPT_MODE, key);
  map = (SerializableMap<String, Integer>) sealedMap.getObject(cipher);

  // Inspect map
  InspectMap(map);
}

Noncompliant Code Example (Seal Then Sign)

This noncompliant code example uses the java.security.SignedObject class to sign an object when the integrity of the object must be ensured. The two new arguments passed in to the SignedObject() method to sign the object are Signature and a private key derived from a KeyPair object. To verify the signature, a PublicKey as well as a Signature argument is passed to the SignedObject.verify() method.

This noncompliant code example signs the object as well as seals it. According to Abadi and Needham [Abadi 1996],

When a principal signs material that has already been encrypted, it should not be inferred that the principal knows the content of the message. On the other hand, it is proper to infer that the principal that signs a message and then encrypts it for privacy knows the content of the message.

Any malicious party can intercept the originally signed encrypted message from the originator, strip the signature, and add its own signature to the encrypted message. Both the malicious party and the receiver have no information about the contents of the original message because it is encrypted and then signed (it can be decrypted only after verifying the signature). The receiver has no way of confirming the sender's identity unless the legitimate sender's public key is obtained over a secure channel. One of the three Internal Telegraph and Telephone Consultative Committee (CCITT) X.509 standard protocols was susceptible to such an attack [CCITT 1988].

Because the signing occurs after the sealing, it cannot be assumed that the signer is the true originator of the object.

public static void main(String[] args)
                        throws IOException, GeneralSecurityException, 
                               ClassNotFoundException {
  // Build map
  SerializableMap<String, Integer> map = buildMap(

public static void main(String[] args)
  throws IOException, GeneralSecurityException, ClassNotFoundException {
  // Build map
  SerializableMap<String, Integer> map = buildMap();

  // Generate sealing key & seal map
  KeyGenerator generator;
  generator = KeyGenerator.getInstance("AES");
  generator.init(new SecureRandom());
  Key key = generator.generateKey();
  Cipher cipher = Cipher.getInstance("AES");
  cipher.init(Cipher.ENCRYPT_MODE, key);
  SealedObject sealedMap = new SealedObject(map, cipher);

  // Generate signingsealing public/private key pair & signseal map
  KeyGenerator generator;
 KeyPairGenerator kpggenerator = KeyPairGeneratorKeyGenerator.getInstance("DSAAES");
   KeyPair kpgenerator.init(new SecureRandom());
  Key key = kpggenerator.generateKeyPairgenerateKey();
  SignatureCipher sigcipher = SignatureCipher.getInstance("SHA1withDSAAES");
  SignedObject signedMap cipher.init(Cipher.ENCRYPT_MODE, key);
  SealedObject sealedMap = new SignedObjectSealedObject(sealedMapmap, kp.getPrivate(), sigcipher);

  // SerializeGenerate signing public/private key pair & sign map
  ObjectOutputStreamKeyPairGenerator outkpg = new ObjectOutputStream(new FileOutputStreamKeyPairGenerator.getInstance("dataDSA"));
   out.writeObject(signedMapKeyPair kp = kpg.generateKeyPair();
  Signature sig = outSignature.closegetInstance("SHA1withDSA");

  //SignedObject DeserializesignedMap map=
  ObjectInputStream  in = new ObjectInputStreamSignedObject(new FileInputStream("data"));
  signedMap = (SignedObject) in.readObject(sealedMap, kp.getPrivate(), sig);

  // Serialize map
  ObjectOutputStream out = 
      new ObjectOutputStream(new FileOutputStream("data"));
  out.writeObject(signedMap);
  inout.close();

  // UnsignDeserialize map
  if (!signedMap.verify(kp.getPublic(), sig)) {
ObjectInputStream in =
     throw new GeneralSecurityExceptionObjectInputStream(new FileInputStream("Map failed verificationdata"));
  }
signedMap = sealedMap = (SealedObject) signedMap.getObject(SignedObject) in.readObject();
  in.close();

  // Unseal Verify signature and retrieve map
  cipher = Cipher.getInstance("AES");
  cipher.init(Cipher.DECRYPT_MODE, keyif (!signedMap.verify(kp.getPublic(), sig)) {
    throw new GeneralSecurityException("Map failed verification");
  map}
  sealedMap = (SerializableMap<String, Integer>SealedObject) sealedMapsignedMap.getObject(cipher);

  // InspectUnseal map
  cipher = InspectMap(map);
}
Cipher.getInstance("AES");
  cipher.init(Cipher.DECRYPT_MODE, key);
  map = (SerializableMap<String, Integer>) sealedMap.getObject(cipher);

  // Inspect map
  InspectMap(map);
}

Compliant Solution (Sign

...

Then Seal)

This compliant solution correctly signs the object before sealing it. This approach provides a guarantee of authenticity to the object , in addition to protection from man-in-the-middle attacks.

public static void main(String[] args)
                        throws
  IOException, GeneralSecurityException, 
                               ClassNotFoundException {
  // Build map
  SerializableMap<String, Integer> map = buildMap();

  // Generate signing public/private key pair & sign map
  KeyPairGenerator kpg = KeyPairGenerator.getInstance("DSA");
  KeyPair kp = kpg.generateKeyPair();
  Signature sig = Signature.getInstance("SHA1withDSA");
  SignedObject signedMap = new SignedObject(map, kp.getPrivate(), sig);

  // Generate sealing key & seal map
  KeyGenerator generator;
  generator = KeyGenerator.getInstance("AES");
  generator.init(new SecureRandom());
  Key key = generator.generateKey();
  Cipher cipher = Cipher.getInstance("AES");
  cipher.init(Cipher.ENCRYPT_MODE, key);
  SealedObject sealedMap = new SealedObject(signedMap, cipher);

  // Serialize map
  ObjectOutputStream out = new
 ObjectOutputStream(new      new ObjectOutputStream(new FileOutputStream("data"));
  out.writeObject(sealedMap);
  out.close();

  // Deserialize map
  ObjectInputStream in =
      new ObjectInputStream(new FileInputStream("data"));
  sealedMap = (SealedObject) in.readObject();
  in.close();

  // Unseal map
  cipher = Cipher.getInstance("AES");
  cipher.init(Cipher.DECRYPT_MODE, key);
  signedMap = (SignedObject) sealedMap.getObject(cipher);

  // UnsignVerify signature and retrieve map
  if (!signedMap.verify(kp.getPublic(), sig)) {
    throw new GeneralSecurityException("Map failed verification");
  }
  map = (SerializableMap<String, Integer>) signedMap.getObject();

  // Inspect map
  InspectMap(map);
}

Exceptions

unmigratedSER02-wikiJ-markup*SER02-EX0:* A reasonable use for signing a sealed object is to certify the authenticity of a sealed object passed from elsewhere. This use represents a commitment _about the sealed object itself_ rather than about its content \[ [Abadi 1996|AA. Bibliography#Abadi 96]\].

SER02-J-EX1: Signing and sealing is required only required for objects that must cross a trust boundary. Objects that never leave the trust boundary need not be signed or sealed. For instanceexample, if when an entire network is contained within a trust boundary, then objects that never leave this that network need not be signed or sealed. Another example is objects that are only sent down a signed binary stream.

Risk Assessment

Failure to sign and then seal objects during transit can lead to loss of object integrity or confidentiality.

Automated Detection

Not This rule is not amenable to static analysis in the general case.

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

Bibliography

.

Related Guidelines

Bibliography

...

Image Added Image Added Image AddedImage Removed      13. Serialization (SER)      SER03-J. Do not serialize unencrypted, sensitive data