A Java OutofMemoryError
occurs if when the program attempts to use more heap space than is available. Among other causes, this error may result from the following:
- a A memory leak (see MSC04-J. Do not leak memory)
- an An infinite loop
- limited Limited amounts of default heap memory available
- incorrect Incorrect implementation of common data structures (hash tables, vectors, and so on)
- unbound Unbounded deserialization
- writing Writing a large number of objects to an
ObjectOutputStream
(see SER10-J. Avoid memory and resource leaks during serialization) - creating Creating a large number of threads.
- uncompressing Uncompressing a file (see IDS04-J. Limit the size of files passed to Safely extract files from ZipInputStream)
Some of these causes are platform-dependent , and difficult to anticipate. Others are fairly easy to anticipate, such as reading data from a file, are fairly easy to anticipate. As a result, programs must not accept untrusted input in a manner that can cause the program to exhaust memory.
Noncompliant Code Example (readLine()
)
This noncompliant code example reads lines of text from a file , and adds each one to a vector , until a line with the word "quit" is encountered.:
Code Block | ||
---|---|---|
| ||
class ShowHeapErrorReadNames { private Vector<String> names = new Vector<String>(); private final InputStreamReader input; private final BufferedReader reader; public ShowHeapErrorReadNames(String filename) throws IOException { this.input = new FileReader(filename); this.reader = new BufferedReader(input); } public void addNames() throws IOException { try { String newName; while (((newName = reader.readLine()) != null) && !(newName.equalsIgnoreCase("quit") == false)) {)) { names.addElement(newName); System.out.println("adding " + newName); } } finally { input.close(); } } public static void main(String[] args) throws IOException { if (args.length != 1) { System.out.println("Arguments: [filename]"); return; } ShowHeapErrorReadNames demo = new ShowHeapErrorReadNames(args[0]); demo.addNames(); } } |
The code places no upper bounds on the memory space required to execute the program. Consequently, the program can easily exhaust the available heap space in two ways. First, an attacker can supply arbitrarily many lines in the file, causing the vector to grow until memory is exhausted. Second, an attacker can simply supply an arbitrarily long line, causing the {{ Wiki Markup readLine()
}} method to exhaust memory. According to the Java API \[documentation [API 2006|AA. Bibliography#API 06]\2014], {{the BufferedReader.readLine()
}} method documentation method
Reads a line of text. A line is considered to be terminated by any one of a line feed ('
\n
'), a carriage return ('\r
'), or a carriage return followed immediately by a linefeed.\[{{readLine()}}\] Reads a line of text. A line is considered to be terminated by any one of a line feed ('{{\n}}'), a carriage return ('{{\r}}'), or a carriage return followed immediately by a linefeed. Wiki Markup
Any code that uses this method is susceptible to a resource exhaustion attack because the user can enter a string of any length.
Compliant Solution (
...
Limited File Size)
This compliant solution imposes limits, both a limit on the length size of each line, and on the total number of items to add to the vector.the file being read. The limit is set with the Files.size()
method, which was introduced in Java SE 7. If the file is within the limit, we can assume the standard readLine()
method will not exhaust memory, nor will memory be exhausted by the while
loop.
Code Block | ||
---|---|---|
| ||
class ReadNames | ||
Code Block | ||
| ||
class ShowHeapError { // ... otherOther methods and variables public static public String readLimitedLine(Reader reader, int limitfinal int fileSizeLimit = 1000000; public ReadNames(String filename) throws IOException { StringBuilderlong sbsize = new StringBuilder()Files.size( Paths.get( filename)); forif (intsize i> = 0; i < limit; i++) { int c = reader.read(fileSizeLimit) { throw new IOException("File too large"); } else if (csize == -10L) { throw new return null; }IOException("File size cannot be determined, possibly too large"); } if (((char) c == '\n') || ((char) c == '\r')) { this.input = new FileReader(filename); this.reader = breaknew BufferedReader(input); } } |
Compliant Solution (Limited Length Input)
This compliant solution imposes limits both on the length of each line and on the total number of items to add to the vector. (It does not depend on any Java SE 7 or later features.)
Code Block | ||
---|---|---|
| ||
class ReadNames { // ... Other methods and variables public static String readLimitedLine(Reader reader, int limit) throws IOException } sb.append((char) c); } return sb.toString(); } static public final int lineLengthLimit = 1024; static public final int lineCountLimit = 1000000; public void addNames() throws IOException { try { StringBuilder sb String newName= new StringBuilder(); for (int i = 0; i < lineCountLimitlimit; i++) { int c newName = readLimitedLine( reader, lineLengthLimitreader.read(); if (newNamec == null-1) { return ((sb.length() break> 0) ? sb.toString() : null); } if ((newName.equalsIgnoreCase("quit")) { (char) c == '\n') || ((char) c == '\r')) { break; } names.addElement(newNamesb.append((char) c); } System.out.println("adding " + newName);return sb.toString(); } public static final }int lineLengthLimit = 1024; public static }final finallyint { lineCountLimit = 1000000; public void input.closeaddNames(); throws IOException { try }{ } } |
The readLimitedLine()
method defined above takes a numeric limit, indicating the total number of characters that may exist on one line. If a line contains more characters, the line is truncated, and they are returned on the next invocation. This prevents an attacker from exhausting memory by supplying input with no line breaks.
Compliant Solution (Java 1.7, limited file size)
This compliant solution impose a limit on the size of the file being read. This is accomplished with the Files.size()
method which is new to Java 1.7. If the file is within the limit, we can assume the standard readLine()
method will not exhaust memory, nor will memory be exhausted by the while
loop.
Code Block | ||
---|---|---|
| ||
class ShowHeapError {
static public final int fileSizeLimit = 1000000;
public ShowHeapError(String filename) throws IOException {
if (Files.size( Paths.get( filename)) > fileSizeLimit) {
throw new IOException("File too large");
}
this.input = new FileReader(filename);
this.reader = new BufferedReader(input);
}
// ...other methods
}
|
Noncompliant Code Example
Wiki Markup |
---|
In a server-class machine using a parallel garbage collector, the default initial and maximum heap sizes are as follows for Java SE 6 \[[Sun 2006|AA. Bibliography#Sun 06]\]: |
- initial heap size: larger of 1/64th of the machine's physical memory on the machine or some reasonable minimum
- maximum heap size: smaller of 1/4th of the physical memory or 1GB
This noncompliant code example requires more memory on the heap than is available by default.
Code Block | ||
---|---|---|
| ||
/** Assuming the heap size as 512 MB (calculated as 1/4th of 2 GB RAM = 512 MB)
* Considering long values being entered (64 bits each, the max number of elements
* would be 512 MB/64bits = 67108864)
*/
public class ShowHeapError {
Vector<Long> names = new Vector<Long>(); // Accepts unknown number of records
long newID = 0L;
int count = 67108865;
int i = 0;
InputStreamReader input = new InputStreamReader(System.in);
Scanner reader = new Scanner(input);
public void addNames() {
try {
do {
// Adding unknown number of records to a list
// The user can enter more IDs than the heap can support and as a result,
// exhaust the heap. Assume that the record ID is a 64 bit long value
System.out.print("Enter recordID (To quit, enter -1): ");
newID = reader.nextLong();
names.addElement(newID);
i++;
} while (i < count || newID != -1);
} finally {
input.close();
}
}
public static void main(String[] args) {
ShowHeapError demo = new ShowHeapError();
demo.addNames();
}
}
|
Compliant Solution
A simple compliant solution is to reduce the number of names to read.
Code Block | ||
---|---|---|
| ||
// ...
int count = 10000000;
// ...
|
Compliant Solution
Wiki Markup |
---|
The {{OutOfMemoryError}} can be avoided by ensuring that the absence of infinite loops, memory leaks, and unnecessary object retention. When memory requirements are known ahead of time, the heap size can be tailored to fit the requirements using the following runtime parameters \[[Java 2006|AA. Bibliography#Java 06]\]: |
java -Xms<initial heap size> -Xmx<maximum heap size>
For example,
java -Xms128m -Xmx512m ShowHeapError
Here the initial heap size is set to 128 MB and the maximum heap size to 512 MB.
This setting can be changed either using the Java Control Panel or from the command line. It cannot be adjusted through the application itself.
Risk Assessment
Assuming that infinite heap space is available can result in denial of service.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
MSC05-J | low | probable | medium | P4 | L3 |
Related Vulnerabilities
The Apache Geronimo bug described by GERONIMO-4224 results in an OutOfMemoryError
exception thrown by the WebAccessLogViewer
if the access log file size is too large, such as more than 200 MB.
Related Guidelines
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="8c62518f-4183-4dce-865d-d306a5807cfe"><ac:plain-text-body><![CDATA[ | [ISO/IEC TR 24772:2010 | http://www.aitcnet.org/isai/] | "Resource Exhaustion [XZP]" | ]]></ac:plain-text-body></ac:structured-macro> |
CWE-400, "Uncontrolled Resource Consumption ('Resource Exhaustion')" | ||||
| CWE-770, "Allocation of Resources Without Limits or Throttling" |
Bibliography
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="d1d6d5b8-6205-454b-b33e-70910fa05921"><ac:plain-text-body><![CDATA[ | [[Sun 2006 | AA. Bibliography#Sun 06]] | [Garbage Collection Ergonomics | http://java.sun.com/javase/6/docs/technotes/guides/vm/gc-ergonomics.html ], "Default values for the Initial and Maximum heap size" | ]]></ac:plain-text-body></ac:structured-macro> |
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="15acd44d-534e-4ce1-9d04-a17e6d20165b"><ac:plain-text-body><![CDATA[ | [[Java 2006 | AA. Bibliography#Java 06]] | [java - the Java application launcher | http://java.sun.com/javase/6/docs/technotes/tools/windows/java.html ], "Syntax for increasing the heap size" | ]]></ac:plain-text-body></ac:structured-macro> |
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="e451241d-1022-4334-9546-44073fde593c"><ac:plain-text-body><![CDATA[ | [[Sun 2003 | AA. Bibliography#Sun 03]] | Chapter 5: Tuning the Java Runtime System, [Tuning the Java Heap | http://docs.sun.com/source/817-2180-10/pt_chap5.html#wp57027] | ]]></ac:plain-text-body></ac:structured-macro> |
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="4f599cdc-f03c-4453-9c94-01c3b2066e02"><ac:plain-text-body><![CDATA[ | [[API 2006 | AA. Bibliography#API 06]] | Class ObjectInputStream and ObjectOutputStream | ]]></ac:plain-text-body></ac:structured-macro> | |
<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="2336e1a7-7de2-44eb-82aa-8cb0a435f97b"><ac:plain-text-body><![CDATA[ | [[SDN 2008 | AA. Bibliography#SDN 08]] | [Serialization FAQ | http://java.sun.com/javase/technologies/core/basic/serializationFAQ.jsp] | ]]></ac:plain-text-body></ac:structured-macro> |
String newName;
for (int i = 0; i < lineCountLimit; i++) {
newName = readLimitedLine(reader, lineLengthLimit);
if (newName == null || newName.equalsIgnoreCase("quit")) {
break;
}
names.addElement(newName);
System.out.println("adding " + newName);
}
} finally {
input.close();
}
}
}
|
The readLimitedLine()
method takes a numeric limit, indicating the total number of characters that may exist on one line. If a line contains more characters, the line is truncated, and the characters are returned on the next invocation. This prevents an attacker from exhausting memory by supplying input with no line breaks.
Noncompliant Code Example
In a server-class machine using a parallel garbage collector, the default initial and maximum heap sizes are as follows for Java SE 6 [Sun 2006]:
- Initial heap size: larger of 1/64 of the machine's physical memory or some reasonable minimum.
- Maximum heap size: smaller of 1/4 of the physical memory or 1GB.
This noncompliant code example requires more memory on the heap than is available by default:
Code Block | ||
---|---|---|
| ||
/* Assuming the heap size as 512 MB
* (calculated as 1/4 of 2GB RAM = 512MB)
* Considering long values being entered (64 bits each,
* the max number of elements would be 512MB/64 bits =
* 67108864)
*/
public class ReadNames {
// Accepts unknown number of records
Vector<Long> names = new Vector<Long>();
long newID = 0L;
int count = 67108865;
int i = 0;
InputStreamReader input = new InputStreamReader(System.in);
Scanner reader = new Scanner(input);
public void addNames() {
try {
do {
// Adding unknown number of records to a list
// The user can enter more IDs than the heap can support and,
// as a result, exhaust the heap. Assume that the record ID
// is a 64-bit long value
System.out.print("Enter recordID (To quit, enter -1): ");
newID = reader.nextLong();
names.addElement(newID);
i++;
} while (i < count || newID != -1);
} finally {
input.close();
}
}
public static void main(String[] args) {
ReadNames demo = new ReadNames();
demo.addNames();
}
}
|
Compliant Solution
A simple compliant solution is to reduce the number of names to read:
Code Block | ||
---|---|---|
| ||
// ...
int count = 10000000;
// ...
|
Compliant Solution
The OutOfMemoryError
can be avoided by ensuring the absence of infinite loops, memory leaks, and unnecessary object retention. When memory requirements are known ahead of time, the heap size can be tailored to fit the requirements using the following runtime parameters [Java 2006]:
java -Xms<initial heap size> -Xmx<maximum heap size>
For example,
java -Xms128m -Xmx512m ReadNames
Here the initial heap size is set to 128MB and the maximum heap size to 512MB.
These settings can be changed either using the Java Control Panel or from the command line. They cannot be adjusted through the application itself.
Risk Assessment
Assuming infinite heap space can result in denial of service.
Rule | Severity | Likelihood | Remediation Cost | Priority | Level |
---|---|---|---|---|---|
MSC05-J | Low | Probable | Medium | P4 | L3 |
Related Vulnerabilities
The Apache Geronimo bug described by GERONIMO-4224 results in an OutOfMemoryError
exception thrown by the WebAccessLogViewer
when the access log file size is too large.
Automated Detection
Tool | Version | Checker | Description | ||||||
---|---|---|---|---|---|---|---|---|---|
CodeSonar |
| JAVA.ALLOC.LEAK.NOTSTORED | Closeable Not Stored (Java) |
Related Guidelines
Resource Exhaustion [XZP] | |
CWE-400, Uncontrolled Resource Consumption ("Resource Exhaustion") |
Bibliography
[API 2014] | |
Java—The Java Application Launcher, Syntax for Increasing the Heap Size | |
[Oracle 2015] | Tuning the Java Runtime System |
[SDN 2008] | |
[Sun 2006] | Garbage Collection Ergonomics, Default Values for the Initial and Maximum Heap Size |
...
49. Miscellaneous (MSC) MSC08-J. Do not modify the underlying collection when an iteration is in progress