Code that does not perform any action, or has an unintended effect can result in unexpected behavior and vulnerabilities. Statements or expressions that have no effect should be identified and removed from code.
Non-Compliant Code Example 1
In this example, the comparison of a to b has no effect.
int a; a == b;
This is likely a case of the programmer mistakenly using the equals operator == instead of the assignment operator =.
Compliant Solution 1
The assignment of b to a is now properly performed.
int a; a = b;
Non-Compliant Code Example 2
In this example, p is incremented and then dereferenced, However, *p has no effect.
int *p; *p++;
Compliant Solution 2
Correcting this example depends on the programmers intent. For instance, if dereferencing p was done on accident, then p should not be dereferenced.
int *p; p++;
If the intent was to increment the value referred to by p, then parentheses can be used to ensure p is dereferenced then incremented EXP00-A..
int *p; (*p)++
Risk Assessment
The presence of code that has no effect could indicate logic errors that may result in unexpected behavior and vulnerabilities.
Recommendation |
Severity |
Likelihood |
Remediation Cost |
Priority |
Level |
|---|---|---|---|---|---|
MSC12-A |
1 (low) |
1 (unlikely) |
2 (medium) |
P2 |
L3 |
Automated Detection
The Coverity Prevent NO_EFFECT checker finds statements or expressions that do not accomplish anything, or statements that perform an unintended action. Coverity Prevent cannot discover all violations of this rule so further verification is necessary.
Related Vulnerabilities
Search for vulnerabilities resulting from the violation of this rule on the CERTwebsite.
References
Coverity 07 Coverity Prevent? User's Manual (3.3.0) (2007).