EXP55-CPP. Do not access a cv-qualified object through a cv-unqualified type

The C++ Standard, [dcl.type.cv], paragraph 4, states [ISO/IEC 14882-2014]:

Except that any class member declared mutable can be modified, any attempt to modify a const object during its lifetime results in undefined behavior.

Similarly, paragraph 6 states:

What constitutes an access to an object that has volatile-qualified type is implementation-defined. If an attempt is made to refer to an object defined with a volatile-qualified type through the use of a glvalue with a non-volatile-qualified type, the program behavior is undefined.

Do not cast away a const qualification to attempt to modify the resulting object. The const qualifier implies that the API designer does not intend for that object to be modified despite the possibility it may be modifiable. Do not cast away a volatile qualification; the volatile qualifier implies that the API designer intends the object to be accessed in ways unknown to the compiler, and any access of the volatile object results in undefined behavior.

Noncompliant Code Example

In this noncompliant code example, the function g() is passed a const int &, which is then cast to an int & and modified. Because the value referenced to was previously declared as const, the assignment operation results in undefined behavior.

void g(const int &ci) {
  int &ir = const_cast<int &>(ci);
  ir = 42;
}

void f() {
  const int i = 4;
  g(i);
}

Compliant Solution

In this compliant solution, the function g() is passed an int &, and the caller is required to pass an int that can be modified.

void g(int &i) {
  i = 42;
}

void f() {
  int i = 4;
  g(i);
}

Noncompliant Code Example

In this noncompliant code example, a const-qualified method is called, which attempts to cache results by casting away the const-qualifier of this. Because s was declared const, the mutation of CachedCalc results in undefined behavior.

#include <iostream>
 
class S {
  int CachedCalc;
  
  int expensiveCompute() const;  
public:
  S() : CachedCalc(0) {}
  
  // ...  
  int Calculate() const {
    if (!CachedCalc) {
      const_cast<S *>(this)->CachedCalc = expensiveCompute();  
    }        
    return CachedCalc;
  }
};

void f() {
  const S s;
  std::cout << s.Calculate() << std::endl;
}

Compliant Solution

This compliant solution uses the mutable keyword when declaring CachedCalc, which allows it to be mutated within a const context without triggering undefined behavior:

#include <iostream>
 
class S {
  mutable int CachedCalc;
  
  int expensiveCompute() const;
public:
  S() : CachedCalc(0) {}
  
  // ...  
  int Calculate() const {
    if (!CachedCalc) {
      CachedCalc = expensiveCompute();  
    }        
    return CachedCalc;
  }
};

void f() {
  const S s;
  std::cout << s.Calculate() << std::endl;
}

Noncompliant Code Example

In this noncompliant code example, the volatile value s has the volatile qualifier cast away, and an attempt is made to read the value within g(), resulting in undefined behavior.

#include <iostream>

struct S {
  int i;
  
  S(int i) : i(i) {}
};

void g(S &s) {
  std::cout << s.i << std::endl;
}

void f() {
  volatile S s(12);
  g(const_cast<S &>(s));
}

Compliant Solution

This compliant solution assumes that the volatility of s is required, and so g() is modified to accept a volatile S &:

#include <iostream>

struct S {
  int i;
  
  S(int i) : i(i) {}
};

void g(volatile S &s) {
  std::cout << s.i << std::endl;
}

void f() {
  volatile S s(12);
  g(s);
}

Exceptions

EXP35-EX1: An exception to this rule is allowed when it is necessary to cast away const when invoking a legacy API that does not accept a const argument, provided the function does not attempt to modify the referenced variable. It is always preferable to modify the API to be const-correct when possible, however. For example, the following code casts away the const qualification of INVFNAME in the call to the audit_log() function.

// Legacy function defined elsewhere - cannot be modified; does not attempt to
// modify the contents of the passed parameter.
void audit_log(char *errstr);

void f() {
  const char INVFNAME[]  = "Invalid file name.";
  audit_log(const_cast<char *>(INVFNAME)); // EXP35-EX1
}

Risk Assessment

If the object is declared as being constant, it may reside in write-protected memory at runtime. Attempting to modify such an object may lead to abnormal program termination or a denial-of-service attack. If an object is declared as being volatile, the compiler can make no assumptions regarding access of that object. Casting away the volatility of an object can result in reads or writes to the object being reordered, or elided entirely, resulting in abnormal program execution.

Automated Detection

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

Related Guidelines

Bibliography