You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 9 Next »

Division and modulo operations are susceptible to divide-by-zero errors.

Division

The result of the / operator is the quotient from the division of the first arithmetic operand by the second arithmetic operand. Division operations are susceptible to divide-by-zero errors. Overflow can also occur during two's complement signed integer division when the dividend is equal to the minimum (negative) value for the signed integer type and the divisor is equal to —1. (See rule "NUM00-J. Detect or prevent integer overflow".)

Noncompliant Code Example

This code can result in a divide-by-zero error during the division of the signed operands sl1 and sl2.

signed long sl1, sl2, result;

/* Initialize sl1 and sl2 */

result = sl1 / sl2;

Compliant Solution

This compliant solution tests the suspect division operation to guarantee there is no possibility of divide-by-zero errors.

signed long sl1, sl2, result;

/* Initialize sl1 and sl2 */

if ( (sl2 == 0) ) {
  /* handle error condition */
}
else {
  result = sl1 / sl2;
}

Modulo

The % operator provides the remainder when two operands of integer type are divided.

Noncompliant Code Example

This code can result in a divide-by-zero error during the remainder operation on the signed operands sl1 and sl2.

signed long sl1, sl2, result;

/* Initialize sl1 and sl2 */

result = sl1 % sl2;

Compliant Solution

This compliant solution tests the suspect remainder operation to guarantee there is no possibility of a divide-by-zero error.

signed long sl1, sl2, result;

/* Initialize sl1 and sl2 */

if ( (sl2 == 0 ) ) {
  /* handle error condition */
}
else {
  result = sl1 % sl2;
}

Risk Assessment

A divide-by-zero can result in abnormal program termination and denial of service.

Recommendation

Severity

Likelihood

Remediation Cost

Priority

Level

NUM19-J

low

likely

medium

P6

L2


NUM17-J. Beware of precision loss when converting primitive integers to floating-point      03. Numeric Types and Operations (NUM)      04. Object Orientation (OBJ)

  • No labels