Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Parasoft Jtest 2021.1

The Object.wait() method temporarily cedes possession of a lock so that other threads that may be requesting the lock can proceed. Object.wait() must always be called from a synchronized block or method. The waiting thread resumes execution only after it has been notified, generally due to as the result of the invocation of the notify() or notifyAll() method by some other thread. The wait() method must be invoked from a loop that checks whether a condition predicate holds. Note that a condition predicate is the negation of the condition expression in the loop. For example, the condition predicate for removing an element from a vector is !isEmpty(), whereas the condition expression for the while loop condition is isEmpty(). The Following is the correct way to invoke the wait() method when the vector is empty is shown below.

Code Block

private Vector vector;
// ...

public void consumeElement() throws InterruptedException {
  synchronized (vector) {
    while (vector.isEmpty()) {
      vector.wait();
    }

    // ConsumeResume when condition holds
  }
}

The notification mechanism notifies the waiting thread and allows it to check its condition predicate. The invocation of notify() or notifyAll() in another thread cannot precisely determine which waiting thread will be resumed. Condition predicate statements allow notified threads to determine whether they should resume upon receiving the notification. Condition predicate predicates are also useful when a thread is required to block until a condition becomes true, for example, when waiting for data to arrive on an input stream before reading the data.unmigrated-wiki-markup

Both safety and liveness   are concerns when using the wait/notify mechanism. The safety property requires that all objects maintain consistent states in a multithreaded environment \[ [Lea 2000|AA. Bibliography#Lea 00]\]. The liveness property requires that every operation or method invocation execute to completion without interruption.

To guarantee liveness, programs must test the while loop condition before invoking the wait() method. This early test checks whether another thread has already satisfied the condition predicate and sent a notification. Invoking the wait() method after the notification has been sent results in indefinite blocking.unmigrated-wiki-markup

To guarantee safety, programs must test the {{while}} loop condition after returning from the {{wait()}} method. Although {{wait()}} is intended to block indefinitely until a notification is received, it still must still be encased within a loop to prevent the following vulnerabilities \[ [Bloch 2001|AA. Bibliography#Bloch 01]\]:

  • thread Thread in the middle—A middle: A third thread can acquire the lock on the shared object during the interval between a notification being sent and the receiving thread resuming execution. This third thread can change the state of the object, leaving it inconsistent. This is a time-of-check-to-, time-of-use (TOCTOU) race condition.
  • malicious notification—A Malicious notification: A random or malicious notification can be received when the condition predicate is false. Such a notification would cancel the wait() method.
  • misdelivered notification—The Misdelivered notification: The order in which threads execute after receipt of a notifyAll() signal is unspecified. Consequently, an unrelated thread could start executing and discover that its condition predicate is satisfied. Consequently, it could resume execution , although it was despite being required to remain dormant.
  • Wiki Markupspurious wake-ups—Certain JVM implementations are vulnerable to spurious wake-ups that result in waiting threads waking up even without a notification \[[API 2006|AA. Bibliography#API 06]\Spurious wakeups: Certain Java Virtual Machine (JVM) implementations are vulnerable to spurious wakeups that result in waiting threads waking up even without a notification [API 2014].

For these reasons, programs must check the condition predicate after the wait() method returns. A while loop is the best choice for checking the condition predicate both before and after invoking wait().

Wiki MarkupSimilarly, the {{await()}} method of the {{Condition}} interface also must also be invoked inside a loop. According to the Java API \ [[API 2006|AA. Bibliography#API 06]\], Interface {{Condition}}API 2014], Interface Condition

When waiting upon a Condition, a "spurious wakeup" is permitted to occur, in general, as a concession to the underlying platform semantics. This has little practical impact on most application programs as a Condition should always be waited upon in a loop, testing the state predicate that is being waited for. An implementation is free to remove the possibility of spurious wakeups but it is recommended that applications programmers always assume that they can occur and so always wait in a loop.

New code should use the java.util.concurrent.locks concurrency utilities in place of the wait/notify mechanism. However, legacy code that complies with the other requirements of this rule is permitted to depend upon on the wait/notify mechanism.

...

This noncompliant code example invokes the wait() method inside a traditional if block and fails to check the post-condition postcondition after the notification is received. When If the notification was were accidental or malicious, the thread could wake up prematurely.

Code Block
bgColor#FFcccc

synchronized (object) {
  if (<condition does not hold>) {
    object.wait();
  }
  // Proceed when condition holds
}

...

This compliant solution calls the wait() method from within a while loop to check the condition both before and after the call to wait().:

Code Block
bgColor#ccccff

synchronized (object) {
  while (<condition does not hold>) {
    object.wait();
  }
  // Proceed when condition holds
}

Invocations of the await() method of the java.util.concurrent.locks.Condition interface must also .await() method also must be enclosed in a similar loop.

Risk Assessment

To guarantee liveness and safety, Failure to encase the wait() and or await() methods must always be invoked inside a while loop can lead to indefinite blocking and denial of service (DoS).

Rule

Severity

Likelihood

Remediation Cost

Priority

Level

THI03-J

low

Low

unlikely

Unlikely

medium

Medium

P2

L3

Bibliography

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="154a5b20-64f8-44dc-9f32-a635883db76b"><ac:plain-text-body><![CDATA[

[[API 2006

AA. Bibliography#API 06]]

[Class Object

http://java.sun.com/javase/6/docs/api/java/lang/Object.html]

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="ef4706e3-865f-441a-b004-516e6e863436"><ac:plain-text-body><![CDATA[

[[Bloch 2001

AA. Bibliography#Bloch 01]]

Item 50: Never invoke wait outside a loop

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="50522fc4-bfc3-4e8f-92fb-11745af0e796"><ac:plain-text-body><![CDATA[

[[Lea 2000

AA. Bibliography#Lea 00]]

3.2.2 Monitor Mechanics, 1.3.2 Liveness

]]></ac:plain-text-body></ac:structured-macro>

<ac:structured-macro ac:name="unmigrated-wiki-markup" ac:schema-version="1" ac:macro-id="2c17be6b-5b64-4054-8839-43ff117a6d8f"><ac:plain-text-body><![CDATA[

[[Goetz 2006

AA. Bibliography#Goetz 06]]

Section 14.2, Using Condition Queues

]]></ac:plain-text-body></ac:structured-macro>

Automated Detection

ToolVersionCheckerDescription
Parasoft Jtest
Include Page
Parasoft_V
Parasoft_V
CERT.THI03.UWILCall 'wait()' and 'await()' only inside a loop that tests the liveness condition
SonarQube
Include Page
SonarQube_V
SonarQube_V
S2274"Object.wait(...)" and "Condition.await(...)" should be called inside a "while" loop

Bibliography

[API 2014]

Class Object
Interface Condition

[Bloch 2001]

Item 50, "Never Invoke wait Outside a Loop"

[Goetz 2006]

Section 14.2, "Using Condition Queues"

[Lea 2000]

Section 1.3.2, "Liveness"
Section 3.2.2, "Monitor Mechanics"


...

Image Added Image Added Image AddedImage Removed      09. Thread APIs (THI)      THI02-J. Notify all waiting threads rather than a single thread