FI039-C. Temporary files must have unique names

Privileged programs that create files in world-writable directories can overwrite protected system files. An attacker who can predict the name of a file created by a privileged program can create a symbolic link (with the same name as the file used by the program) to point to a protected system file. Unless the privileged program is coded securely, the program will follow the symbolic link instead of opening or creating the file that it is supposed to be using. As a result, a protected system file to which the symbolic link points can be overwritten when the program is executed.

Non-Compliant Code Example: open()

The following statement creates some_file in the /tmp directory.

int fd = open("/tmp/some_file", O_WRONLY | O_CREAT | O_TRUNC, 0600);

If /tmp/some_file already exists then that file is opened and truncated. If /tmp/some_file is a symbolic link, then the target file referenced by the link is truncated.

To exploit this coding error, an attacker need only create a symbolic link called /tmp/some_file before execution of this statement.

Non-Compliant Code Example: O_CREAT and O_EXCL

This vulnerability can be prevented by including the flags O_CREAT and O_EXCL when calling open().

int fd = open("/tmp/some_file", O_WRONLY | O_CREAT | O_EXCL | O_TRUNC, 0600);

This call to open() fails whenever /tmp/some_file already exists, including when it is a symbolic link.
Care should be observed when using O_EXCL with remote file systems as it does not work with NFSv2 (but is supported in NFSv3 and later).

The problem with this solution is that open() can fail if /tmp/some_file already exists. One solution is to generate random file names and attempt to open() each until we find a unique name. Luckily, there are predefined functions that do this for us.

Non-Compliant Code Example: tmpnam()

The C99 tmpnam() function generates a string that is a valid file name and that is not the same as the name of an existing file [[ISO/IEC 9899-1999]]. Files created using strings generated by the tmpnam() function are temporary in that their names should not collide with those generated by conventional naming rules for the implementation. The function is potentially capable of generating TMP_MAX different strings, but any or all of them may already be in use by existing files. If the argument is not a null pointer, it is assumed to point to an array of at least L_tmpnam chars; the tmpnam() function writes its result in that array and returns the argument as its value.

...
if (tmpnam(temp_file_name)) {
  /* temp_file_name may refer to an existing file */
  t_file = fopen(temp_file_name,"wb+");
  if (!t_file) {
     /* Handle Error */
  }
}
...

Unfortunately, this solution is still non-compliant because it violates [[FIO32-C]], [[FI041-C]], [[FI042-C]].

Non-Compliant Code Example: tmpnam_s()

The TR 24731-1 tmpnam_s() function generates a string that is a valid file name and that is not the same as the name of an existing file [[ISO/IEC TR 24731-2006]]. The function is potentially capable of generating TMP_MAX_S different strings, but any or all of them may already be in use by existing files and thus not be suitable return values. The lengths of these strings must be less than the value of the L_tmpnam_s macro.

...
FILE *file_ptr;
result = tmpfile_s(&file_ptr);
if (result != 0) {
  /* Handle Error */
}
t_file = fopen_s(temp_file_name, "wb+");
if (!t_file) {
   /* Handle Error */
}
...

This example needs to be checked

Non-Compliant Code Example 2 (POSIX)

The POSIX function mktemp() is similar to tmpnam() save it allows the user to specify a template to use for the unique file name. Like tmpnam(), mktemp() may introduce a TOCTOU race condition. The following example demonstrates this.

...
FILE *temp_ptr;
char temp_name[] = "/tmp/temp-XXXXXX";

if (mktemp(temp_name) == NULL) {
  /* Handle Error */
}
temp_ptr = fopen(temp_name,"w+");
if (temp_ptr == NULL) {
  /* Handle Error */
}
...

Compliant Solution 2 (POSIX)

A reasonably secure solution for generating random file names in UNIX is to call the mkstemp() function as follows:

char sfn[15] = "/tmp/ed.XXXXXX";
FILE *sfp;
int fd = -1;

if ((fd = mkstemp(sfn)) == -1 || (sfp = fdopen(fd, "w+")) == NULL) {
  if (fd != -1) {
    unlink(sfn);
    close(fd);
  }
  fprintf(stderr, "%s: %s\n", sfn, strerror(errno));
  return (NULL);
}

Risk Assessment

A protected system file to which the symbolic link points can be overwritten when a vulnerable program is executed.

References

• ISO/IEC 9899-1999 Sections 7.19.4.3 The tmpfile function, 7.19.4.4 The tmpnam function
• ISO/IEC TR 24731-2006 Section 6.5.1.1 The tmpfile_s function