SCP01-J. Declare sensitive methods private or final, fields private and final, and classes to be final

According to [JLS Section 8.4.8.3, Requirements in Overriding and Hiding]:

"The access modifier of an overriding or hiding method must provide at least as much access as the overridden or hidden method, or a compile-time error occurs."

The allowed accesses are:

This also means that there is potential for some functionality having a restrictive modifier to be overridden by a less restrictive modifier.

Noncompliant Code Example

This noncompliant code example exemplifies how a malicious subclass Sub can override the doLogic method of the super class. Any user of Sub will be able to invoke the doLogic method since the base class BadScope defined it with the protected access modifier. The class Sub can allow more access than BadScope by using the public modifier.

class BadScope {
  protected void doLogic() { System.out.println("Super invoked"); }
}

public class Sub extends BadScope {
  public void doLogic() { 
    System.out.println("Sub invoked");
    //do restrictive operations
  }
}

Compliant Solution

Do not override a method unless absolutely necessary. Declare all methods and fields final to avoid malicious subclassing. This is in compliance with the tenets of OBJ31-J. Do not use public static non-final variables and OBJ00-J. Declare data members private.

class BadScope {
  private final void doLogic() { System.out.println("Super invoked"); }
}

Risk Assessment

Subclassing allows access restrictions to be weakened, possibly compromising the security of a Java application.

Automated Detection

TODO

Related Vulnerabilities

Search for vulnerabilities resulting from the violation of this rule on the CERT website.

References

[[JLS 05]] Section 8.4.8.3, Requirements in Overriding and Hiding
[[MITRE 09]] CWE ID 487 "Reliance on Package-level Scope"

SCP00-J. Use as minimal scope as possible for all variables and methods      04. Scope (SCP)      SCP02-J. Do not expose private members of the outer class from within a nested class