SEI CERT Oracle Coding Standard for Java

Space shortcuts

Page tree

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 24 Next »

Current status.

Dhruv – ???

Dean – Ch. 4.

Robert – ???

Fred - Ch. 5.

David - ???

Completed

Chapter 1:  rCs, dm, dfs, fwl

Chapter 2: dfs, fwl

Chapter 3:  rCs (dm edited original version by mistake - merging required), dfs

Chapter 4:  dm, dms

Chapter 5: dms

Replaceable (weak) guidelines

 

 

 

 

This page contains adhoc TODO ideas or topics being currently investigated. Please feel free to comment on these or suggest new ones.

Possible Changes to Current Guidelines
  • All classes, methods will need to include the final keyword. Although this is against extensibility, it is critical from the security point of view.
  • All file separators must be replaced by platform independent File.separator
  • Possibly use the memento design pattern with deserialization. An inner class performs input validation using 'safe' objects, for example, long to store int vals and then updates the state of the actual outer class and so on..., Item 50 [Daconta 03]
  • readResolve() for deserialization (singletons). Do not serialize sensitive external mutable variables (best to declare them transient)
  • Calling clone.super() is necessary.
Possible Recommendations
  • Do not serialize keys, certificates or the classes that contain their instances, as deserialization may fail if the same security provider is not present at the remote end. Instead, override the readObject, writeObject methods and encode the data. [P 202 Oaks 01] (unsure if this can be classified as a security error) (done)
  • Careful while using environment variables - investigate usual conditions (done)
  • Use HttpSession carefully, Item 25 [Daconta 03]
  • For good portability, do not make the assumption - all DBMSs can tolerate several open ResultSet Objects at a time, Item 41 [Daconta 03]
  • Thread.interrupted issues
  • Java encoding issues (done)
  • Prefer composition over inheritance (done)
  • Avoid flaws in interfaces (done)
  • Naming conventions (will not do)
  • Check nonpublic method's params using assertions rather than normal checks (done)
  • Create defensive copies of method params (done)
  • Prefer interfaces to abstract classes (will not do)
  • Prefer interfaces to Reflection (methods) (will not do)
  • Failure Atomicity (exceptions should not leave object state inconsistent) (done)
  • Avoid ThreadGroup APIs (done)
  • Masking, Shadowing, Obscuration (done)
  • Issues with ProtectionDomains (if any)
Possible Rules
  • Poor performance and DoS due to regex (fixed in jdk 1.6)
  • Do not catch Error (done)
  • Avoid using Reflection to instantiate inner classes
  • Use a typesafe enum pattern [Bloch, Item 20]- (enum type provided, jdk 1.5 onwards, Docs)
  • Do not hardcode sensitive information (done)
  • compareTo() contract violations like natural ordering that is not consistent with equals (done)
  • Don't catch Throwable without checking for ThreadDeath. (will not do)
  • Usage of GetResource may be unsafe if class is extended [Findbugs]
  • Do not serialize/deserialize resource handles (done)
  • Do not sign encrypted data (SignedObject should be first, followed by SealedObject) (done)
  • No labels